Ok, not sure how I managed to miss this before. Tests with mocked git don't work on windows due to mock-git and its dep mock-bin:
mock-bin creates an executable script with a shebang, which windows does not support, PR: (https://github.com/stevemao/mock-bin/pull/3)mock-git doesn't escape slashes, PR: (https://github.com/stevemao/mock-git/pull/3)mock-git has no version range in its mock-bin dependency thus not getting the windows fix when it lands, issue: (https://github.com/stevemao/mock-git/issues/5)Both of these packages will need updates to make the mock tests work. I have created PRs in the respective repos and verified that standard-version tests are fixed with them. This issue is to track the progress of those fixes.
All issues resolved, just waiting on a mock-git release.
@Tapppi digging into the AppVeyor stuff, I'm pretty stumped. A few things I noticed:
true, I wonder if this is somehow getting picked up in the formatting string.CC: @nexdrew
@bcoe, I'm gonna sum the CI shenanigans here since it's been all over the place now. @nexdrew 's comment in the other PR had everything right, so:
CI env var is exactly the thing breaking the build. The var can't be removed and thus the formatting string (with the %ci% env var reference) needs to be changed. Explanation can be found in @nexdrew 's comment and above it in mine. I'll create PRs in conventional-changelog-core tonight, unless someone can do it before me, formock-git tests dont work, but will be fixed as soon as @stevemao releases a new version of mock-git with the fixes outlined in this issue's OP.@bcoe @nexdrew @stevemao does this clear this stuff up finally? That should be a good push forward IMO.
Also, @nexdrew to answer your question of what blocks Windows usage: Nothing! :blush: I'm using this package daily on Windows.
mock-git should work on Windows now.
Closed #57 and renamed this to reflect the fact that, at least IMO, this is the best place to track the Appveyor CI issues for now.
Opened PRs for appveyor config on conventional-changelog-core and git-raw-commits. Also opened windows fix PR in git-raw-commits: https://github.com/conventional-changelog/git-raw-commits/pull/10. It's the most logical place, since it will actually fix all percent sign variable expansion problems by escaping them on windows.
@Tapppi this agrees with what I was seeing, moving forward with fixes seems smart to me ... I don't think any of us want to spin up Windows VMs too frequently, having AppVeyor in place to stop regressions will be nice.
So unfortunately my previous fix to git-raw-commits was a non-fix.. Opened a new PR with an actual fix and tests to confirm it...
All but node 0.10 work now, with git-raw-commits v1.1.2. Don't have time right now to delve into that..
https://ci.appveyor.com/project/Tapppi/standard-version/build/29
@Tapppi I'm pretty comfortable with removing Node 0.10 from Windows integration tests, if you don't have time to dig into this further ... gets us to a much better place than where we were.
Yeah I think that's the best move forwards.
@Tapppi great work!
Thanks @tapppi!
Most helpful comment
@Tapppi this agrees with what I was seeing, moving forward with fixes seems smart to me ... I don't think any of us want to spin up Windows VMs too frequently, having AppVeyor in place to stop regressions will be nice.