Hello,
I wanted to do some experiments on the geospatial indexes added with Redis 3.2, but I realized they are not implemented in StackExchange.Redis.
After a bit of search, I found pull request #381 but it seems to be dead.
Do you still have plans to support this feature ?
Thanks
I second this request!
Redis Geo is an important feature; please support.
Also agree!
Looks like WJD made a commit last month, so it doesn't seem dead as much as not moving ahead terribly quickly.
I think an issue with this right now is that the Geo features were added in redis 3.2, and the highest nuget package available for redis is 3.0. This means you can't just clone the repo, rebuild the solution, and run tests. Their latest stable binary is 3.2 however, so I'd think they should be close to getting this done.
So I grabbed WJD's branch and forked it, updated it from the main repo, neatened it up, wrote some tests, and got all the geo functionality he'd put together working along with async versions, etc, etc. I did have to modify Message to allow an argument to be passed along inside of it. Seemed like a good idea at the time:
https://github.com/caseymarquis/StackExchange.Redis/commits/master
Not really sure how pull requests work as we don't use them internally at my 9 to 5, but if anyone's interested in integrating this, then let me know. Or just steal it. Preferably that.
I need this for a personal project, so I'm just going to start using it as is, but if there's an interest in getting this into the main project let me know and I'll do what I can to help if I've got some time. Seems like there were some issues with newlines or something at some point, which probably makes direct merging a PITA; so someone would probably have to play with things a bit. Not sure if that came from WJD, myself, or if the repo was in a weird state to begin with. Best.
Please, I implore you, put a high priority on the GEO-commands so that their functionality can be put to use. I'm working on a project where the GEOADD and GEORADIUS commands would be extremely useful to reduce the size of a query but I can't use them. I'll clone and try to use caseymarquis's fork from WJD, but if that doesn't work then I'm stuck with having to retrieve a bunch of data I don't need that will be filtered away server-side which is a complete waste. Please get the GEO-commands up and running ASAP!
@Renti if you're looking to push this the extra mile to get it integrated, I'd guess the todo list would be to:
My fork worked in testing, so it shouldn't be too far from something you can use.
I've scheduled some time on SE.Redis, and getting the geo API finished up
and deployed is top of the list.
On 16 Nov 2016 4:04 pm, "Ertin Bahceci" [email protected] wrote:
Please, I implore you, put a high priority on the GEO-commands so that
their functionality can be put to use. I'm working on a project where the
GEOADD and GEORADIUS commands would be extremely useful to reduce the size
of a query but I can't use them. I'll clone and try to use caseymarquis's
fork from WJD, but if that doesn't work then I'm stuck with having to
retrieve a bunch of data I don't need that will be filtered away
server-side which is a complete waste. Please get the GEO-commands up and
running ASAP!—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/StackExchange/StackExchange.Redis/issues/496#issuecomment-260985881,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABDsGNodq3UyKaYtzdm_O533H6yry4Tks5q-ylRgaJpZM4KHglL
.
This is now available in https://www.nuget.org/packages/StackExchange.Redis/1.2.0-alpha1
Closing.
Most helpful comment
This is now available in https://www.nuget.org/packages/StackExchange.Redis/1.2.0-alpha1
Closing.