Squirrel.windows: No feedback if downloading fails.

Created on 28 May 2019  路  1Comment  路  Source: Squirrel/Squirrel.Windows

Squirrel version(s)
1.9.1 from NuGet

Description
No error returned if, during downloading, something happens (like disconnection from network).

Steps to recreate
using (UpdateManager mgr = new UpdateManager(URL via HTTP/HTTPS))
{
try
{
var updateInfo = await mgr.CheckForUpdate().ConfigureAwait(true);
//... suppose you have some updates to download and apply
Console.WriteLine($"Starting download of version {updateInfo.FutureReleaseEntry.Version}.");
var t = mgr.DownloadReleases(updateInfo.ReleasesToApply, OnDownloadUpdatesProgressValue);
await t.ConfigureAwait(true);
//if downloading doesn't fail, execution continue from here as expected
//if downloading fails (you can try removing network cable during downloading) code doesn't fall in catch or elsewhere, simply continue without any feedback to my code
LogInstance.Info($"Downloading of version {updateInfo.FutureReleaseEntry.Version} completed with success.");
OnDownloadingUpdatesCompleted(this, new OperationResultEventArgs { Value = true });
}
catch (Exception ex)
{
LogInstance.Error("8F93975E-> {0}", ex.ToString());
OnDownloadingUpdatesCompleted(this, new OperationResultEventArgs { Value = false });
return;
}
}

Expected behavior
I'm expecting that a downloading issue raises an exception or similar

Actual behavior
Nothing is raised and execution continues like nothing happens

Additional information
I've try with await t.ConfigureAwait(false) but nothing change; I can't see any event to attach to for detecting this faulting condition

Most helpful comment

I've discovered the solution myself: the .DownloadReleases() function has a timeout of about 10mins., so before that time interval nothing happens. Thanks!

>All comments

I've discovered the solution myself: the .DownloadReleases() function has a timeout of about 10mins., so before that time interval nothing happens. Thanks!

Was this page helpful?
0 / 5 - 0 ratings