Sqlite_orm: Version issue

[AlexandrePTJ]

Hello,

It's looks like there is an issue with how project is tagged.

From github view, release 1.3 exists since the April 9th 2019, but the git tag 1.3 is on September 15th 2018.

[fnc12]

Hello. Thanks for using the lib.
Why is this a problem?

[fnc12]

IDK why github does this. Probably tag was created once I created a release draft for 1.3 version

[AlexandrePTJ]

It is a problem for package creation because we rely on tag.

[fnc12]

How can we fix it?

[AlexandrePTJ]

I looks like I confused the v1.3 tag and the date of the release annoucement. 1.3 was ready on september but It have been annouced 3 weeks ago, so this what leads me to this confusion.
However v1.3 is not working for package creation, we will wait for the next release and stick to v1.2.

But I don't understand why the PR from https://github.com/fnc12/sqlite_orm/pull/159/files is not in v1.3 release.

[fnc12]

Maybe the reason is that I created a draft release many weeks before I published it. I think it is a genuine practice. This must not confuse package manager or someone else.
git tag shows

1.3
v1.0
v1.1
v1.2
v1.3

Looks like we need to remove 1.3 tag to keep it in order.
Also why do you think that v.1.3 doesn't have 159th PR?
Run

git checkout v1.3
git log | grep "64437a6175cf4b9656586ebd2504c507e5d3ca64"
git log | grep "d507843b14f3fe4c6583244fb4f82af0e2213bce"

And you'll get correct output: commits 64437a6175cf4b9656586ebd2504c507e5d3ca64 and d507843b14f3fe4c6583244fb4f82af0e2213bce are the only commits from 159th PR and they do exist in v.1.3

[DoozyX]

Also when exploring github tags it doesn't show the new commits.

It is the same with gitkaken.

[fnc12]

@DoozyX I don't understand what exactly you expect when you are exploring github tags. Where do you expect new commits to show? You can view new commits by pressing commits button to the left from branches. Every tag keeps commit list immutable

[DoozyX]

I think the v1.3 tag should be where you merged the pull request from dev to master, so when people download the source at the 1.3 tag they can get the new changes, atm they download the source from 6 months ago

[fnc12]

I recreated v1.3 tag and synced it with current master branch state. Not tag v1.3 is up to date with true 1.3 version. Do I need to fix older tags? Also IDK why this happened but I will pay more attention during future releases

[soroshsabz]

@fnc12 Did you can remove older v1.3 ? so if you can successfully removed duplicate tag we can see one tag on https://github.com/fnc12/sqlite_orm/tags

thanks

[fnc12]

I removed 1.3 tag

[soroshsabz]

@fnc12 thanks for it, so I think this issue can close :)

[AlexandrePTJ]

Thanks, for works well.