Sqldelight: Lots of name shadowed warnings in query wrappers

[benasher44]

Build Environment
SQLDelight version: 1.4.3
OS: macOS
Gradle version: 6.6
Kotlin version: 1.4.10
AGP Version (if applicable):

Describe the bug
As a result of #1926, the parameter names of the generated lambda often shadow the parameter names of the enclosing function. This results in lots of Name shadowed warnings. If this isn't easily fixable or is intended, it would be great to generate a @Suppress for these.

[gildor]

Thanks for fixing this! Are there any plans to have a patch release with this fix?

[AlecStrong]

No plans for that, no.

[eygraber]

Any chance that can be reconsidered? My project is blocked on updating to Kotlin 1.4 by this, because we have the "treat warnings as errors" option enabled.

Not sure if the fact that I caused the issue helps or hurts my request 😬

[benasher44]

This is still happening to me in SQLDelight 1.4.4.

[eygraber]

The issue has been fixed in all of my projects where it was happening.

Did you try a clean build?

[benasher44]

Yep! Did ./gradlew clean <build>

[benasher44]

Looks like it's still broken in cases where a query wrapper calls the lambda variant of the query wrapper and passes all of the params to a data class— something like:

 override fun selectOne(id: String?): Query<TableName> = selectOne(id) { id
    TableName(
      id
    )
  }

[eygraber]

:thinking:

That's my use case, and it works for me. id in the lambda parameter list should be id_. I just verified that's what's happening in my project.

Can you check that clean is actually deleting your build directories? Every once in a while that stops working for me.

[benasher44]

Never mind. It turns out I was still using the 1.4.3 plugin. It's fixed. Sorry about that!