Sqldelight: Release for Kotlin 1.4 support

Created on 27 Jul 2020 · 10Comments · Source: cashapp/sqldelight

Tracking issue

Blocked on:

[x] kotlinx.coroutines 1.3.9 release
- [x] kotlinx.coroutines 1.3.9 regular release
- [x] kotlinx.coroutines 1.3.9-native-mt release
[x] Stately release for 1.4
[x] Sqliter release for 1.4
[x] Turbine release for 1.4 (https://github.com/cashapp/turbine/issues/6)
[ ] Update to Kotlin 1.4

Source

JakeWharton

👍17 👀9

Most helpful comment

Working on it. We're releasing all the things on 1.4-rc

kpgalligan on 27 Jul 2020

🎉11 🚀1

All 10 comments

Working on it. We're releasing all the things on 1.4-rc

kpgalligan on 27 Jul 2020

🎉11 🚀1

Is hope to release version of SQLDelight corresponding to 1.4.0-rc or will you be waiting for final 1.4 release?

joreilly on 1 Aug 2020

I am personally not super enthusiastic about having a release build against an RC.

JakeWharton on 1 Aug 2020

I was more wondering I guess whether there might be an SQLDelight "1.4.-rc" version released (prior to proper 1.4 release)....as has been done for example for ktor, kotlinx serialization etc. I'm not sure how close we are to 1.4 release and whether it's worth the effort or not (and of course that's your call :) ). One other area this impacts is those projects that are tracking Jetpack Compose dev releases which has recently moved to being 1.4 based.

joreilly on 1 Aug 2020

It only impacts them if they're using native, right? Android, JVM, and JS projects should work fine with the current release I believe.

We're getting closer to automatic releases so if all our dependencies have updated we may be able to pull an RC release off. At the very least, let's get master and snapshots on 1.4 ASAP.

JakeWharton on 1 Aug 2020

👍2

fwiw I'm running into some issues with the sqldelight gradle plugin and kotlin 1.4-rc: https://issuetracker.google.com/issues/162779407
Not sure if updating SQLdelight to use 1.4-rc will fix but figured it was worth raising.