Sqldelight: Kotlin native 1.3.70 support

[mikezliu]

Kotlin 1.3.70 has been released

[JakeWharton]

We also have dependencies that need to release first. We're aware of the new versions and will work towards a release as soon as it's viable.

[GianfrancoMS]

Any updates?

[JakeWharton]

Updates will come as comments or changes to the status of this issue.

[JakeWharton]

Notably, we were blocked by kotlinx.coroutines 1.3.5-mt availability so now that it's available things are progressing.

[brendanw]

For anyone eager to give sqldelight a run on 1.3.71, you can checkout https://github.com/cashapp/sqldelight/tree/jakew/seventy-one/2020-03-24, run ./gradlew installArchives, and add your local maven repository to your plugin repositories:

    maven {
      url = uri("/Users/YourUsernameHere/.m2/repository")
    }

I am not seeing a compelling reason for the upgrade. Investing effort into updating sqldelight locally to use 1.4-M1 as build times are significantly improved.

[benasher44]

Xcode 11.4, which just came out, comes with a nice Swift bug that will break (runtime crash) with (likely all) K/N frameworks built using a version earlier than Kotlin 1.3.70. That's the compelling reason to upgrade for us, anyway.

[kpgalligan]

Also, mt coroutines has had an update in 1.3.71, and any library fixes out
in the wild will be targeting 1.3.71 as well.

Here's a branch that builds off of Jake's. I ran into some JS and intellij
plugin issues, so have made some temporary compromises on those.

On Tue, Mar 31, 2020 at 1:19 PM Ben Asher [e-mail] wrote:

Xcode 11.4, which just came out, comes with a nice Swift bug that will
break (runtime crash) with (likely all) K/N frameworks built using a
version earlier than Kotlin 1.3.70. That's the compelling reason to upgrade
for us, anyway.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/cashapp/sqldelight/issues/1623#issuecomment-606761588,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AAAQWIAA6QKHQH6QSMTR4C3RKIQYPANCNFSM4LDM4OLQ
.

--
Kevin Galligan
https://twitter.com/kpgalligan

[AlecStrong]

i think both js and intellij are low priority in general, i would be fine shipping a release with 1.3.71 to unblock people's KN version, and then we can follow up re-enabling the plugin and js. Do you have things in a PR-able state?

[kpgalligan]

Yeah, but let me run the tests again. Mentioned in ASG, but not sure if you're getting notifications in there or whatever.

[kpgalligan]

CI failed, which brings up a question I've been wondering. How do you get the sample version of the plugin available to the build.gradle?

// Used for the sample
    classpath "com.squareup.sqldelight:gradle-plugin:${versions.sqldelight}"

Locally I comment that and samples out, and push locally, but is there a better way to do that? Building against the previous version would fail for native because 1.2.2 is using kotlin 1.3.61.

[JakeWharton]

Sounds like we should spin samples out of the main build, perhaps into a composite build?

[AlecStrong]

we should definitely switch to composite builds for the sample. Probably just another thing to comment out while we get 1.3.70 working?

[Ti-m]

Hey,

This is resolved? At least for iOS?

I just built my iOS framework successfully with
Kotlin Native 1.3.72

sourceSets["commonMain"].dependencies {
    implementation("com.squareup.sqldelight:runtime:1.3.0")
…
}

sourceSets["iosMain"].dependencies {
    implementation("com.squareup.sqldelight:native-driver:1.3.0")
…
}

[AlecStrong]

ya