Sql-docs: Non-consistent blue SQL keywords. Extra fluff in results shown.

Created on 3 Jun 2020  Â·  5Comments  Â·  Source: MicrosoftDocs/sql-docs

Under the section "Fractional seconds" in the SQL example, both "millisecond" and "nanosecond" should be blue to be consistent.

Under the section "Examples":
In the 1st example SQL, there is an unneeded "*/".

In the 4th example SQL, the "SELECT TOP(1) DATEPART (year,'12/20/1974') FROM dbo.DimCustomer;" can be rewritten as "SELECT DATEPART(year,'12/20/1974');" as there are no columns used in the FROM clause. This would also make the comment "-- Uses AdventureWorks" unneeded.

Also, examples 3 & 5 do not need the "--------" above the result.

Thanks!


Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

Pri1 cba doc-enhancement sqprod t-sqtech

All 5 comments

@Protiguous -- thank you for your keen eye. I am looking into this article.

You are welcome! I like to think that I'm helping.
Now.. How can I get paid to edit these pages myself? Haha! (hmm..)

If notifying your editors of these when I come across them is *not *annoying,
shall I keep sending in notifications?

On Wed, Jun 3, 2020 at 4:45 PM William Anton Rohm notifications@github.com
wrote:

@Protiguous https://github.com/Protiguous -- thank you for your keen
eye. I am looking into this article.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/MicrosoftDocs/sql-docs/issues/4906#issuecomment-638499940,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AI3GVIELOXGQITR43CGSQGTRU3HCHANCNFSM4NRYC2WQ
.

@Protiguous -- you are welcome to send in anything you find!

@Protiguous When you're suggesting a simple change to the documentation, it may be faster for you to submit the edit yourself via a Pull Request (PR). You can do so by following these steps:

  1. Navigate to the page of interest
  2. Select the "Edit" button at the top right of the page
  3. Select the "Pencil" icon on the right
  4. Modify the text within the text box in markdown format
  5. Name your file change and copy the link to your Git Issue into the "extended description" box
  6. Select "Propose file change"
  7. Select "Create pull request" on the 'Comparing changes' page
  8. Select "Create pull request" on the 'Open a pull request' page
  9. Wait for an author to review and approve the change request - this can take a bit depending on the complexity

Doing so will allow authors to directly add your text to the documentation. This also displays your github image on the page of authors, and list you as a contributor to the documentation.

Thanks again for your submission!

@Protiguous -- I've tidied up the examples per your suggestions, except:

  • For the blue inconsistency, you have uncovered a possible bug in the SQL code formatter. I am following up with our docs people.
  • I think the 4th and 5th examples are designed to show more context.

Thank you for your feedback!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

EamonNerbonne picture EamonNerbonne  Â·  3Comments

eliotg picture eliotg  Â·  3Comments

sam-s4s picture sam-s4s  Â·  4Comments

samrueby picture samrueby  Â·  3Comments

404
hfleitas picture hfleitas  Â·  3Comments