Spyder: Overwritten file permissions on save

[daniel-edler]

Description

If one saves a file it a) cannot follow my symlink and b) removes my file permissions such that it's not executable anymore. In other words I think on each save the original file is deleted and replaced by a new one

What steps will reproduce the problem?

Click save

Versions

• Spyder version: 4.0.0b2
• Python version: 3.6.7
• Qt version: 5.12.3
• PyQt5 version: 5.12.2
• Operating System: Linux 4.15.0-50-generic

Dependencies

pygments >=2.0     :  2.4.0 (OK)
qdarkstyle >=2.6.4 :  2.6.8 (OK)
sphinx >=0.6.6     :  2.0.1 (OK)
psutil >=0.3       :  5.6.2 (OK)
pyls >=0.19.0;<0.25:  0.24.0 (OK)
nbconvert >=4.0    :  5.5.0 (OK)
pandas >=0.13.1    :  0.23.4 (OK)
numpy >=1.7        :  1.16.3 (OK)
sympy >=0.7.3      :  1.1.1 (OK)
cython >=0.21      :  0.26.1 (OK)
qtconsole >=4.2.0  :  4.4.4 (OK)
IPython >=4.0      :  7.5.0 (OK)
matplotlib >=2.0.0 :  2.2.2 (OK)
pylint >=0.25      :  2.3.1 (OK)

[ccordoba12]

In other words I think on each save the original file is deleted and replaced by a new one

That's correct. This is the behavior since beta2 to ensure that we write atomically on disk. The only thing we can fix is preserving file permissions but not working with symlinks.

@dalthviz, please take a look at this one.

[ccordoba12]

@dalthviz, we also need to avoid opening symlinks in the Editor.

[daniel-edler]

Thanks for your reply.
Ok, I can understand your decision to introduce atomic writing which avoids corrupted or incomplete files at any time(?). My rather exotic case is it store the files in one place and execute the files via symlinks somewhere else. But since I use a separate terminal I'm not really affected by this new behaviour. Just a change of habit.
Anyway, can't you follow the symlink and save it there (with the same file permissions as before)?

[goanpeca]

Anyway, can't you follow the symlink and save it there (with the same file permissions as before)?

You mean that opening a symlink should open the file it points to always?

[daniel-edler]

Yes, that's what I meant. But I haven't thought it through

[jitseniesen]

You mean that opening a symlink should open the file it points to always?

This makes a lot of sense to me.

[ccordoba12]

But that makes atomic write saves harder for us to handle.

[jitseniesen]

As I understand it, the suggestion is that if A is a symlink pointing to B and the user opens A, then Spyder should open B instead. At that point, we can forget about A, so I don't think it makes saves harder.

[goanpeca]

That is how I understand it as well

[daniel-edler]

At least the part with using the same file permissions doesn't seem to be too complicated. How about a bounty of 10€ until end of June? (So it's more a promise to donate on open collective)

[ccordoba12]

@daniel-edler, sorry, we don't work that way. We don't receive bounties for specific features from users. I decide what we should prioritize for each release and use the OpenCollective money to pay the students that work for the project a certain amount of hours per month.

So, users really need to trust that we're going to invest their donations in the best interests of the project. However, if you want to see this implemented faster, you're more than welcome to send us a pull request for it.

[daniel-edler]

Ok. So let's see if I can fix it