Spring-session: Improve Hazelcast client-server topology integration tests

Created on 6 Oct 2019  路  2Comments  路  Source: spring-projects/spring-session

Instead of providing Hazelcast server config via system properties in our client-server topology integration tests, we could simplify things by copying config file to default location thus overriding the default one provided in the container.

This will also help us with adopting to changes from testcontainers/testcontainers-java#1814, that are preventing us to upgrade to Testcontainers 3.12.1+.

backported task

Most helpful comment

Yep, I've just left a comment there.

All 2 comments

@vpavic wait... did https://github.com/testcontainers/testcontainers-java/pull/1814 break your code? o_O

It was supposed to be a backward-compatible change and, if it did, it sounds like a regression! 馃槰

Yep, I've just left a comment there.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

hantsy picture hantsy  路  3Comments

lglapinski picture lglapinski  路  4Comments

sirianni picture sirianni  路  7Comments

YLombardi picture YLombardi  路  10Comments

abincai picture abincai  路  6Comments