Spring-security: Fix non-standard HTTP method for CsrfWebFilter

Created on 19 Mar 2020  路  5Comments  路  Source: spring-projects/spring-security

I expected the matcher to not trigger NPE's (resulting in HTTP 500's) but rather choosing to match or not for unknown methods.

This line triggers the NPE as getMethod returns null for any unmappable method string.
https://github.com/spring-projects/spring-security/blob/06fdb83fb89840c511b2bc46f72b7c49229c9dab/web/src/main/java/org/springframework/security/web/server/csrf/CsrfWebFilter.java#L190

web duplicate bug

All 5 comments

Thanks for the report @Robbert1.
Would you be interested in submitting a PR?

@eleftherias @rwinch how is it for contribution? I can look into it.

Thanks for the offer @parikshitdutta. The issue is yours!

Hi @eleftherias @rwinch, Please take a look at PR #8452, or Please assign it to respective reviewer.

Thank you.

Closed in favor of gh-8452

Was this page helpful?
0 / 5 - 0 ratings