Spring-security: SEC-2536: Provision to change ldap/Ad provider url at run time

[spring-issuemaster]

sagar bhandare (Migrated from SEC-2536) said:

Hi,
Currently the ldap or active directory url can be passed only at application start up through xml or java configuration. There is no provision to update the url without restarting the application. I have achieved this for ldap by extending LdapAuthenticationProvider, setting properties on abstractContextSource and calling afterPropertiesSet method. For ActiveDirectoryLdapAuthenticationProvider its not possible as the class is marked as final.
Is there any chance we can provide this as a part of framework itself?

[spring-issuemaster]

Michael Osipov said:

This is a common problem in the entire Spring Framework not limited to Spring Security. The only option I see is to use XML config and call refresh on the framework. Java config is static.

[spring-issuemaster]

Rob Winch said:

You never need Spring to do Dependency Injection as any code can invoke a setter method (that is the beauty of Dependency Injection).

If you need to dynamically change the URL, I would recommend using the composite pattern. For example:

public DynamicAuthenticationProvider implements AuthenticationProvider {
    private AuthenticationProvider delegate;

    public synchronized Authentication authenticate(Authentication authentication)
        throws AuthenticationException {
        return delegate.authenticate(authentication);
    }

    public synchronized boolean supports(Class<?> authentication) {
        return delegate.authenticate(authentication);
    }

   public void configure(String domain, String url) {
        ActiveDirectoryLdapAuthenticationProvider delegate = new ActiveDirectoryLdapAuthenticationProvider(domain, url);
        ...
        synchronized(this) {
            this.delegate = delegate;
        }
   }
}

[spring-issuemaster]

sagar bhandare said:

Thanks a lot Rob, I wonder why I made things such complicated. I was trying to update the singleton bean created by spring at start up. Your solution makes my code much cleaner and solves my problem. :) Thanks for your help.

[spring-issuemaster]

Rob Winch said:

You are quite welcome. I'm glad I could help. Closing this issue as invalid per feedback.