Spring-cloud-sleuth: `TraceWebClientAutoConfiguration` needs to remove injection of RestTemplates and @PostConstruct init `method`

[ezraroi]

The new code in 1.3.2 is using the Customizer pattern but the code that injects all rest templates and adds the interceptor was not deleted.

This is making that applications will not be able to create RestTemplate bean using the RestTemplateBuilder as a circular dependency is now created:

CloudRestTemplateAutoConfigure:

@Configuration
public class CloudRestTemplateAutoConfigure {

    @LoadBalanced
    @Bean
    public RestTemplate loadBalanced(RestTemplateBuilder restTemplateBuilder) {
        return restTemplateBuilder.build();
    }

    @Bean
    @Primary
    public RestTemplate restTemplate(RestTemplateBuilder restTemplateBuilder) {
        return restTemplateBuilder.build();
    }
}

Also looks like the RestTemplateCustomizer traceRestTemplateCustomizer() needs to have LOWEST_PRECEDENCE and not HIGHEST_PRECEDENCE as you want to make sure you add it as the first customizer and no other customizer is adding to the start of the list after your code

[ezraroi]

You can find a simple project that was generated with start,spring.io with Slueth and Web only and reproduces it.

https://github.com/ezraroi/SpringSluethRestTemplateIssue

[marcingrzejszczak]

🤦‍♂️

[ezraroi]

Looks like the code that adds the interceptors to a RestTemplate created with new will stop working... as RestTamplate should be created with the RestTemplateBuilder.

Tried to fix the code in my fork and looks like you have tests that tests that tracing is working with RestTemplate not created by the builder

[marcingrzejszczak]

I guess, I've fixed it. Also I've updated a test to prove that it works with 2 RestTemplates at a time, one created via builder and one via new. https://github.com/spring-cloud/spring-cloud-sleuth/commit/d62756e3b116fa8dc818a6388043c46c773c8e69

[brenuart]

Any idea of when 1.3.3.RELEASE is gona happen ?

[marcingrzejszczak]

Hopefully soon... until then just disable spring.sleuth.web.client.enabled: false

[brenuart]

We'll wait until then... maintaining workarounds is too expensive (unless it takes months to get the new release ;-)

[marcingrzejszczak]

hehehe, no, I think this one will be much sooner ;)

[brenuart]

Will it be part of an Edgware.SR3 or an independent release of "Sleuth only" ?

[marcingrzejszczak]

part of Edgware.SR3

[brenuart]

Damn! You guys are going too fast...

[brenuart]

Any ETA update for Edgware.SR3 ?

[marcingrzejszczak]

https://repo.maven.apache.org/maven2/org/springframework/cloud/spring-cloud-sleuth-core/ it's there. We will announce it today I guess.

[brenuart]

Cool. Can’t wait for it… 😉