Spring-cloud-sleuth: Add JDBC instrumentation

[marcingrzejszczak]

[yanglifan]

Other than add JDBC instrumentation, may be can intercept Spring Data Repositories and Templates.

[marcingrzejszczak]

You can already use the Spring Data Repositories together with Sleuth's annotations.

[yanglifan]

But cannot add annotations on methods like save(), findOne()

[marcingrzejszczak]

Why? You can inherit a method in your interface and annotate it

[yanglifan]

Yes, but a little ugly.

[gavlyukovskiy]

I have created a library that is proxying your DataSource with one of the jdbc instrumentation libraries such as p6spy.
It as well integrates with sleuth and registers listener that is very similar to the one from brave-instrumentation-p6spy, but mine is also creating span for each connection taken from the DataSource and query span includes time to close ResultSet if query returns it.

In zipkin it looks great:

You can find more screenshots and try it on library page.

[marcingrzejszczak]

That looks awesome @gavlyukovskiy . Let's do it like this. Everyone who is interested in this feature please try the https://github.com/gavlyukovskiy/spring-boot-data-source-decorator library. Once we get more parties involved and happy with the library we'll think of putting it in the core of Sleuth.

[marcingrzejszczak]

Closing this in favour of Brave's p6spy instrumentaiton - https://github.com/openzipkin/brave/tree/master/instrumentation/p6spy#brave-instrumentation-p6spy