Spring-cloud-netflix: Rename starters to include `-netflix-`
All the starters in the other projects include more context.
spring-cloud-starter-consul-discovery, or spring-cloud-starter-zookeeper-config.
I would only do this post Brixton, in the C release train.
spencergibb
All 21 comments
Add the new starters in Dalston, remove old starters in Edgware
spencergibb
on 5 Oct 2016
I've started working on this issue. I'm having second though on spring-cloud-starter-eureka. When I started on Spring Cloud, I remember getting confused between spring-cloud-starter-eureka and spring-cloud-starter-eureka-server.
How about renaming the client to spring-cloud-starter-netflix-eureka-client ? I know it's getting long... but we can't escape thespring-cloud-starter-netflix-eureka-server.
daniellavoie
on 24 Apr 2017
@daniellavoie, yeah that makes sense.
spencergibb
on 24 Apr 2017
Adjustment coming through ;) Made a first PR with the old name.
daniellavoie
on 24 Apr 2017
NP
spencergibb
on 24 Apr 2017
@philwebb what does boot do when they rename/deprecate a starter? It would be nice to print a warning that the user is using a deprecated starter.
spencergibb
on 24 Apr 2017
We update the name and description. See https://github.com/spring-projects/spring-boot/commit/fc00e4cbe0d5a1f9f83e5148df2b36e8b11943f1 for an example.
philwebb
on 24 Apr 2017
Nice, so you do log a warning. Thanks @philwebb
spencergibb
on 24 Apr 2017
Just pushed a new version with the shiny spring-cloud-starter-netflix-eureka-client
daniellavoie
on 24 Apr 2017
@daniellavoie, feign shouldn't be spring-cloud-starter-netflix-feign since it's not netflix anymore. Either keep it spring-cloud-starter-feign or spring-cloud-starter-openfeign. What do you think @adriancole.
spencergibb
on 25 Apr 2017
@spencergibb I understand your point but given this logic, feign should not be part of the spring-cloud-netflix project anymore then. Still, I'll rename it once @adriancole provides us his preference.
daniellavoie
on 25 Apr 2017
spring-cloud-starter-openfeign looks good to me as it reflect the actual project name. If you google around feign alone then you will be directed to the former Netflix stuff...
My 2 cents...
brenuart
on 25 Apr 2017
@daniellavoie yup, it should move out of netflix. Maybe during 2.0.0.
spencergibb
on 24 May 2017
I like spring-cloud-starter-openfeign
spencergibb
on 24 May 2017
What's the next next train after Edgware ? I'll deprecate the old starters with a new issue / PR.
daniellavoie
on 25 May 2017
Finchley
ryanjbaxter
on 25 May 2017
@daniellavoie so it would be nice to have the deprecations in Edgware so they can be removed in Finchley.
spencergibb
on 25 May 2017
Re-opening. If we are deprecating in 1.4.0, shouldn't we remove in 2.0.0? Also, the turbine-amqp starter can probably be retired in 1.4.0 (it was only kept for backwards compatibility). I'm also not convinced we need the hystrix-dashboard starter.
dsyer
on 26 Jul 2017
yes, we should remove them. Nice catch on jar vs pom packaging.
spencergibb
on 26 Jul 2017
@spencergibb @dsyer I think we should close this issue and open a separate issue for removing the starters in 2.0.0. This issue was focused on renaming them in Edgware. I think it will be cleaner if we have a separate issue for Finchley that removes them.
ryanjbaxter
on 18 Aug 2017
Closing this issue, opened separate issues for the starters that need to be removed.
ryanjbaxter
on 21 Aug 2017
Related issues
jjparsons
路
3Comments
hetzijzo
路
3Comments
todd-wang-in-BJ
路
3Comments
sprgn
路
3Comments
hotblac
路
3Comments
Most helpful comment
spring-cloud-starter-openfeignlooks good to me as it reflect the actual project name. If you google aroundfeignalone then you will be directed to the former Netflix stuff...My 2 cents...