Spring-cloud-gateway: Add more filters

[spencergibb]

• [X] Add Request Header
• [X] Add Response Header
• [ ] Set Request Header
• [X] Set Response Header
• [X] Remove Request Header
• [X] Remove Response Header
• [X] Rewrite Path
• [X] Set Path
• [X] Redirect To
• [X] Set HTTP Status
• [X] Hystrix
• [X] Ribbon (Via Spring Cloud LoadBalancerClient)
• [X] Set Query Param
• [ ] Remove Query Param (Might take a PR in spring-framework, would make AddRequestParameter easier).
• [ ] Request Size
• [ ] Compress
• [ ] Spring Retry
• [ ] CORS
• [ ] Tee (ala unix tee): send one request to two places, ignoring one response from skipper
• [ ] Rate Limiting: token-bucket, rolling-rate-limiter (NodeJS/Redis), GCRA go, GCRA Java or here zuul-throttle filter
• [ ] Simian Army Filters (latency, random text, bandwidth limits) #64
• [ ] Versioning?

[spencergibb]

See 0105e57ac8bf198795689ef4d6bc592794ddb6e9 for sample token-bucket filter.

[checketts]

I'm working with Rate limiters too via filters. I really want to have the 3 prong approach we see here: https://stripe.com/blog/rate-limiters working with a Spring Cloud project.

[spencergibb]

I'll take a look

[spencergibb]

Nice, lots of code too!

[spencergibb]

@checketts check out 34e6366.

[checketts]

Wow that looks very clean with good potential for extensibility eventually. The Lua part scares me a bit since I don't understand how that integrates or changes the atomicity of the redis call.

I've been trying to reason through a non-redis implementation, likely Memcached. Would porting the Lua code into Java client code be sufficient?

[spencergibb]

https://redis.io/commands/eval#atomicity-of-scripts

I like that this is run in production at stripe.

[mdiskin]

Looking to migrate off our commercial gateway (CA). Main features we use today are for SOAP services would there be anything to re-implement those:

• [ ] Require/Add WS-Security Signature, Signed Timestamp/Element
• [ ] Evalute XPATH, XSLT
• [ ] Protect against Message Reply

We use SpringWS but these were not extensively supported but possible in the WSS4j side. Looking if it's an easy switch over to CXF (3.2) that supports Spring Boot.

[sbartram]

I have a concurrent request rate limiter implemented on Redis using the same model as RedisRateLimiter and the Stripe rate limiters. Before I spend time prepping the code for a pull request, I'd like to know if there is interest?

Thanks

[spencergibb]

@sbartram if you're talking about the "Concurrent Request Rate Limiter" from https://stripe.com/blog/rate-limiters, then yes, there is interest.

[re6exp]

I'm working on filters that rewrite request/response body.

Now they successfully work with string body, url encoded, json objects.

In plans to add support of multipart/form-data and sse post-processing to complete the set of data conversions how it has been done in Spring Webflux handlers concerning codecs and readers/writers.

See comment.

Have you interest?

[spencergibb]

@re6exp yes, PRs welcome

[dragontree101]

i also want to rewrite request/response body, hold can pr to spring-cloud-gateway .
thanks

[re6exp]

@spencergibb
Ok, after I will finish text-stream-based response rewritting, I'm going to prepare code to PR and release it. At the moment I have to deepen my Flux knowledge to solve it - I'm being in reading docs... After this, the form-multipart rewritting remains, I hope I will also do it. The progress can be viewed here. Any comments or suggestions are welcome.

[spencergibb]

@re6exp wow, that is major complex. I hope that is not what is ultimately needed. If it is, it will be a separate optional module.

[ninja-panda]

Hi All, Is Request Size limiting is available ?

[domainname]

How about Set Response Content filter? I would love to see it on the list.

[re6exp]

@spencergibb @domainname
Here are some blocked changes that can be useful.

[spencergibb]

Closing. Let's track filters individually now. Please open new issues.