Spring-boot: Include system scoped artifacts in repackage goal

Created on 23 Dec 2014 · 10Comments · Source: spring-projects/spring-boot

Currently only runtime, compile and provided are included in the final jar when repackaging for a runnable jar, given that provided are already being packaged it makes sense that system scoped artifacts can be included too.

The simplest workaround is setting a private maven repo but if you are using system scope usually you can not set up your own maven repo.

enhancement

Source

friscoMad

Most helpful comment

There is an includeSystemScope that you can use to add system-scope dependencies to the fat jar.

snicoll on 24 May 2016

🎉5 👍2

All 10 comments

I don't think we should do this by default as it's possible that existing users are depending on this behavior. I've also seen system dependencies used quite often to refer to lib/tools.jar which we would definitely not want to package inside a "fat jar".

Perhaps a switch to enable it would be a nice enhancement.

philwebb on 23 Dec 2014

I woudn't do that either. Maybe including it explicitly by adding an "include" in the plugin's configuration? @frisco82 would that work for you?

snicoll on 24 Dec 2014

Having a configuration switch is perfect for me or even an list of artifact to include aside of the default ones.
I tried the includes configuration but it seems that it does not search for system scoped artifacts and indeed replaces the whole list of artifacts to include (or at least I was unable to make it work).

friscoMad on 24 Dec 2014

good point. The switch is probably the easiest solution.

snicoll on 24 Dec 2014

Base on my understanding, the system scope defined by maven means it will be available in both compile & runtime.
So it's reasonable to support system scoped jar included in runtime lib via repackage.

xfcjscn on 18 May 2015

Looking forward to this!

Usecase where I see this is with some wrapper libraries not available in maven - and CI server being operated centrally and not liking people adding stuff to repositories on their own, or running own repositories.

huima on 11 Sep 2015

@xfcjscn that's actually not accurate: system is exactly like provided. Since Spring Boot embeds the actual process, we have a specific way of handling provided dependencies. From that perspective, it makes sense indeed to handle system scoped dependencies as well.

snicoll on 24 May 2016

There is an includeSystemScope that you can use to add system-scope dependencies to the fat jar.

snicoll on 24 May 2016

🎉5 👍2

Nice work @snicoll !!