Spring-boot: Allow shutdown endpoint to accept GET
Kubernetes can trigger a shutdown but only by issuing a GET. Our current shutdown endpoint only accept POST which makes it unusable.
philwebb
All 5 comments
See #18244
snicoll
on 17 Sep 2019
I really don't like this. GET requests should have no side-effects and be idempotent. Shutting down the app on GET violates both of those. My understanding is that Kubernetes will send SIGTERM to initiate shutdown. Can't we rely on that instead?
wilkinsona
on 17 Sep 2019
I raised this when watching @saturnism present Kubernetes best practices at a conference. Looking at the documentation, I'm not really sure why the HTTP method would be used over SIGTERM. Perhaps Ray can comment?
philwebb
on 18 Sep 2019
If you would like us to look at this issue, please provide the requested information. If the information is not provided within the next 7 days this issue will be closed.
spring-projects-issues
on 25 Sep 2019
Closing due to lack of requested feedback. If you would like us to look at this issue, please provide the requested information and we will re-open the issue.
spring-projects-issues
on 2 Oct 2019
Related issues
techpavan
路
3Comments
ShawnTuatara
路
3Comments
rwinch
路
3Comments
hadrienk
路
3Comments
wilkinsona
路
3Comments
Most helpful comment
I really don't like this.
GETrequests should have no side-effects and be idempotent. Shutting down the app onGETviolates both of those. My understanding is that Kubernetes will sendSIGTERMto initiate shutdown. Can't we rely on that instead?