Spring-boot: Include DispatcherServlets only exposed as a ServletRegistrationBean in the mappings endpoint

Created on 15 May 2018  路  3Comments  路  Source: spring-projects/spring-boot

When a DispatcherServlet is registered via:

@Bean
public ServletRegistrationBean<DispatcherServlet> idmServlet(MyProperties properties) {
    return registerServlet(properties.getServlet(), IdmEngineRestConfiguration.class);
}

Then when the mappings endpoint is invoked then the
context.application.mappings.servlet correctly contains that servlet information. However, under context.application.mappings.dispatcherServlets only the dispatcherServlet and not my custom servlet mappings are displayed.

It would be good if ServletRegistrationBean(s) are also considered as part of the MappingsEndpoint

superseded bug

Most helpful comment

github doesn鈥檛 make a difference between an issue and a PR. We鈥檒l use the PR to track the issue described here so this issue becomes a duplicate of it.

All 3 comments

Closing in favor of PR #13211

@philwebb just out of my curiosity (want to understand how your labels are working). You closed this in favor of the PR (this part I get). You then marked it as duplicate, I assume a duplicate of the PR, but the PR is actually a fix for this issue.

github doesn鈥檛 make a difference between an issue and a PR. We鈥檒l use the PR to track the issue described here so this issue becomes a duplicate of it.

Was this page helpful?
0 / 5 - 0 ratings