Spring-boot: PropertySourcesKey doesn't recognize a replaced property source with the same name
All 12 comments
Looking at SpringConfigurationPropertySources.PropertySourceKey I'm wondering if we can't just keep a weak reference to the original property source.
philwebb
on 12 Mar 2018
forcing the SpringConfigurationPropertySources.onChange() to always fire, fixed the issue. So fixing the key should work.
spencergibb
on 12 Mar 2018
Looking at the shouldTrackChanges testcase for SpringConfigurationPropertySources which seems a bit dodgy, given that it currently constructs a new SpringConfigurationPropertySources instead of verifying that the original has seen the changes.
JoostK
on 13 Mar 2018
@JoostK It does indeed, thanks for highlighting it. We'll fix that at the same time.
philwebb
on 15 Mar 2018
Thanks Phil!
spencergibb
on 16 Mar 2018
@spencergibb Can you give cloud another go just to double check?
philwebb
on 16 Mar 2018
will do
spencergibb
on 16 Mar 2018
@philwebb looks good.
spencergibb
on 16 Mar 2018
@philwebb As mentioned in 328 I tested our project against 2.0.1.BUILD-SNAPSHOT and the issue is resolved. Thanks for fixing it!
sanderino666
on 28 Mar 2018
@philwebb Hi Phil. Is there any chance of this fix getting backported into version 1.5?
ismail-s
on 12 Jun 2018
@ismail-s The bug was in the new ConfigurationProprtySource code introduced in 2.0. The problem shouldn't exist in 1.5.
philwebb
on 12 Jun 2018
@philwebb Thanks for the quick response. I've created spring-cloud/spring-cloud-config#1062 instead.
ismail-s
on 13 Jun 2018
Related issues
Dasiu
路
3Comments
hanusto
路
3Comments
developmentMLPN
路
3Comments
wilkinsona
路
3Comments
wilkinsona
路
3Comments
Most helpful comment
@philwebb looks good.