Spreed: links with ports don't render

Created on 3 Apr 2020  路  9Comments  路  Source: nextcloud/spreed

Steps to reproduce

  1. share a link with a port in a chat, for example https://cloud.josandcamila.com:444/call/.....
  2. See that it remains plain text
  3. 馃槶

Expected behaviour

Should render as a link

Actual behaviour

馃槶

1. to develop bug chat 馃挰 good first issue

All 9 comments

hehe
label fight

Actually it needs fixing in https://github.com/juliushaertl/vue-richtext/blob/master/src/RichText.vue#L26
But still a good starter issue :sunglasses:

First try, hope this is right...

Thanks a lot @SystemKeeper

@SystemKeeper want to make another PR here to update the lib to 0.3.1?
https://github.com/nextcloud/spreed/blob/master/package.json#L19

@nickvergessen I'll try, still new to this...
Just to be sure: After changing the package.json I run "npm install" and commit both package.json and package-lock.json? Or is changing package.json enough here?

Run npm install and commit both, yeah 馃槑

@nickvergessen Thanks for confirming :) Done and pushed - hope this works now.

Thanks a lot, feel free to pick another issue from https://github.com/nextcloud/spreed/labels/good%20first%20issue and continue :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

danxuliu picture danxuliu  路  3Comments

nickvergessen picture nickvergessen  路  5Comments

q-wertz picture q-wertz  路  3Comments

jospoortvliet picture jospoortvliet  路  3Comments

ChristophAGietl picture ChristophAGietl  路  4Comments