Spreed: Missing required prop: "icon" for ActionText

Created on 22 Nov 2019  Â·  3Comments  Â·  Source: nextcloud/spreed

Steps to reproduce

  1. Have a conversation in your list
  2. Open the … menu on it in the navigation

Expected behaviour

No error in console

Actual behaviour

[Vue warn]: Missing required prop: "icon"

found in

---> <ActionText> at src/components/ActionText/ActionText.vue
       <Actions> at src/components/Actions/Actions.vue
         <RouterLink>
           <AppContentListItem> at src/components/Navigation/ConversationsList/AppContentListItem/AppContentListItem.vue
             <Conversation> at src/components/Navigation/ConversationsList/Conversation.vue

The problem is
https://github.com/nextcloud/spreed/blob/d40a337e8183ed11d41561b03232d01c322a4d6b/src/components/Navigation/ConversationsList/Conversation.vue#L54-L55

It does (and should) not have an icon, because it is the caption. I guess we should either add a ActionCaption, or we need to ask for the text component to be allowed without an icon.

cc @ma12-co @skjnldsv

bug

All 3 comments

we need to ask for the ActionText component to be allowed without an icon.

Agreed :)

Closing as per above

Was this page helpful?
0 / 5 - 0 ratings