Spotless: Add support for removing unused imports
Please add support to detect and remove unused imports
oljeger
All 6 comments
This may be difficult to do, according to https://github.com/google/google-java-format/issues/72.
Does Spotless have access to all Java sources by default in a Gradle project it's applied to? If so, this problem may actually be approachable (but almost certainly not easy to figure out). :)
jbduncan
on 29 Oct 2016
Does Spotless have access to all Java sources by default in a Gradle project it's applied to?
Yes and no. Spotless mostly constrains formatters to be Function<String, String>, but if you implement FormatStep directly, then you can see the actual File object being formatted. Inside of JavaExtension (which is where you create the FormatSteps), you have access to the full gradle project, so you can grab the JavaPluginConvention and get the full classpath and sources.
It could certainly be done :)
nedtwigg
on 31 Oct 2016
Implemented in 3.0.0.BETA2 #63
nedtwigg
on 6 Jan 2017
Speak of the devil.... I could have just used this: https://github.com/junit-team/junit5/commit/0672e2904cd51786961a3851f5504e93eab9de59
Looking forward to this feature in 3.0.0!
sbrannen
on 6 Jan 2017
Has this feature only been implemented for the Gradle Plugin? No Maven support?
mstolin
on 18 Mar 2019
Nope, it's in maven too. Search removeUnused in https://github.com/diffplug/spotless/blob/master/plugin-maven/README.md
nedtwigg
on 18 Mar 2019
Related issues
PoonamGargAgarwal
路
3Comments
netvl
路
6Comments
ZacSweers
路
3Comments
ubuntudroid
路
6Comments
fabriziocucci
路
5Comments
Most helpful comment
Yes and no. Spotless mostly constrains formatters to be
Function<String, String>, but if you implementFormatStepdirectly, then you can see the actualFileobject being formatted. Inside ofJavaExtension(which is where you create the FormatSteps), you have access to the full gradle project, so you can grab theJavaPluginConventionand get the full classpath and sources.It could certainly be done :)