Spotipy: user id's are not URL percent encoded

[william-reed]

user id's are not URL encoded and results in some 404 errors when usernames contain symbols. Can be solved simply by using urllib.parser.quote but it seems this repository is no longer updated so I am posting this more as a public service announcement than anything else.

[stephanebruckert]

To review https://github.com/plamere/spotipy/pull/350/

[MaZderMind]

This can be easily triggered by using the E-Mail-Address as Username, which works for all calls that do not pass the username as an argument.

[ritiek]

It'd be nice if someone can provide an example method where this issue can be replicated. I tried passing username and email address to sp.user(), but it seems to fail for email address both with or without percent encoding. I'm probably doing something wrong I think.

[MaZderMind]

I triggered it by running the test-suite with an email-address as username.

[Bressan09]

Taking a look at the Spotify API itself, it states that the parameter to the users endpoint must be an userid, so I guess that the email-address will not work even with the encoding.
For the usernames I will try to make an pull request to fix this as soon as I found an userid that contains special characters to test with.

[stephanebruckert]

@Bressan09 thanks! Also note that there is https://github.com/plamere/spotipy/pull/350, what do you think of it? I am not sure myself in what scenario this is needed

[stephanebruckert]

Closing this as I don't think Spotify allows emails as possible usernames anymore