Spongeapi: ItemEnchantment level overflow

[mbax]

ItemEnchantment throws an exception in the constructor for negative levels, but allows values greater than Short.MAX_VALUE which is pretty much the Minecraft limit. This results in the value overflowing to a negative level, which causes other problems in SpongeAPI (see #1337)

I'm not sure if this is a SpongeAPI concern or an implementation concern, but I'm starting this issue out here.

tl;dr

[kinggoesgaming]

Love the tldr

[JBYoshi]

Just understood the tldr. It's not just a funny picture, it has a real meaning.

Spoiler (base64 decode it): b3ZlcmZsb3c=

[kashike]

https://github.com/SpongePowered/SpongeAPI/commit/eb4a79b997e44d7ebd3e4b9144cb06bf2b6c01fa