Sponge: Server crash when DetonateExplosiveEvent is cancelled

[phit]

Reopening here, original issue https://github.com/SpongePowered/SpongeVanilla/issues/349

Server encounters 'java.lang.IllegalStateException: not primed' and dies when DetonateExplosiveEvent is canceled.

Build number: 1.12.1-7.0.0-BETA-327
Server log: https://pastebin.com/peWkgXsQ

I am installing my plugin, but no other plugins.
This is the code that I guess causing this error:

@Listener
public void onDetonateExplosive(DetonateExplosiveEvent event) {
        event.setCancelled(true);
}

Same with SF 1.12.2-2529-7.0.0-BETA-2742.

[parlough]

@JBYoshi I know you were fixing some things with explosions previously. Is this connected or could you handle this?

[JBYoshi]

Not connected, but this seems to be an easy fix. I just need to test it.

[ryantheleach]

@JBYoshi I'm not 100% sure that this is the correct fix, What is the correct definition of Primed? Maybe it shouldn't be checking the primed state at all?

[JBYoshi]

"Primed" means it will explode. "Defuse" means cancelling a future (primed) explosion. During the event, the TNT is still "primed" because it only explodes after the event finishes.

[ImMorpheus]

Tested on SpongeForge 1.12 (bleeding branch)

I'm not able to reproduce the crash, this can be closed.

[phit]

@ryantheleach you reopened this, status?

[ryantheleach]

It was reopened based on looking at the code, not the error.

Basically, I see fused explosives as having the following timeline.

fuseTicking -> primed -> exploding.

The problem is the edge cases at the transitions, during the event the fix made it seem like a tnt could be BOTH in primed state and in exploding state.

In my mind they are mutually exclusive. exploding is the state after primed.

During the event, the TNT is still "primed" because it only explodes after the event finishes.

Covered most of the concerned I had, but is the TNT considered exploding in the detonate event if it happens before the explosion?

[Zidane]

Closing this, open a new issue ryan and don't take over this issue. The original issue, the crash, is fixed.