Spoke: enhance AdminIncomingMessage view

Created on 19 Mar 2018  Â·  10Comments  Â·  Source: MoveOnOrg/Spoke

Make it filterable

  • [x] Incoming messages that have not been responded to.
  • [x] All messages for a campaign.
  • [x] All messages for a campaign that have not been responded to.
  • [x] All messages.

Implement this with extensibility in mind (to filter for other things, such as profanity).

Make the messages actionable

  • Commandeer selected message(s), which will assign them to the current admin user

Implement this with extensibility in mind.

Notes

This work is a prerequisite for #359.

This work will involve removing the /allmessages endpoint and replacing it with a graphql root query.

A-message review C-meta O-wfp-priority

Most helpful comment

I think reassign to any user is best! It encompasses commandeering so :+1:

All 10 comments

It'd be great if this also included (as display and filter options): assignee, timestamp, and time since response –

Then our review workflow could be filter by unresponded, sort by time since response, and work through it

@ben-pr-p When you say "work through it" are you ok with the concept of commandeering for the current user? Thinking about it, would reassign to any user be better?

I think reassign to any user is best! It encompasses commandeering so :+1:

@lperson @ibrand @deasterdaywfp @suegibson @bchrobot @ben-pr-p - I think the work @lperson has done on Message Review accomplishes all the goals laid out here, though I can't tell (with my limited coding skillz) if this was accomplished - "Implement this with extensibility in mind (to filter for other things, such as profanity)". Thoughts?

@lperson what do you think? Does this feel done and encompassed by message review?

Not sure I am understanding, but I would NEVER “reassign to any user”, only to a specific texter.

@ibrand This is evolving largely due to ongoing input from @suegibson. Unfortunately the most recent iterations currently live in the WFP fork. The WFP parity project includes several pieces of work related to this.

@suegibson I think "reassign to any user" means "reassign to any user YOU CHOOSE.

@joemcl yes, it's sort of designed with extensibility in mind. Tagging and filtering by tag in message review would move us in that direction.

Ok! Nice that's helpful. I'm labeling it as C-meta for now since it encompasses a lot of sub-changes

Checking in @lperson since this seems to be largely accomplished! Though I can't know for sure, I also have limited code skilz

cc @schuyler1d

Yes, all of these are in main

Was this page helpful?
0 / 5 - 0 ratings