Spinnaker: [ECS] Deck doesn't show instance status correctly

[awsiv]

Issue Summary:

Deck doesn't show instance status correctly

Cloud Provider(s):

ecs

Environment:

debian local install
spinnaker 1.20.0
ECS/fargate with service discovery enabled

Feature Area:

spinnaker/deck

Description:

When deploying ECS cluster with Service Discovery enabled, UP status is reported incorrectly in deck.

Starting and Down are reported correctly
Starting:

UP (cluster/instance is green):

Steps to Reproduce:

Enable service discovery for ECS service

[piradeepk]

@awsiv thanks for reporting this issue. This issue arises from https://github.com/spinnaker/clouddriver/blob/master/clouddriver-ecs/src/main/java/com/netflix/spinnaker/clouddriver/ecs/services/ContainerInformationService.java#L153-L154, in which the platformHealthState is set to unknown when the task status is Running.

We can make a change to update the behaviour to another status such as RUNNING but, we will need to investigate further to understand what(if any) the repercussions might be if we update the state to be something different. For instance, if Orca and/or any other Spinnaker services are expecting unknown in order to mark a deployment/task as successfully running.