Spectrum: Focusable elements are not focused making it difficult to know what you're interacting with

Created on 21 Nov 2018 · 15Comments · Source: withspectrum/spectrum

Issue Type (check one)

[x] Bug Report

Description (type any text below) -->

When tabbing through the Spectrum interface it's difficult to know what you're interacting with since the outlines for tabbable elements have been removed.

If you force outlines back on you can see what is being tabbed.

*:focus {
    outline: 3px solid orange !important;
    outline-offset: -2px;
}

You might want to consider https://github.com/WICG/focus-visible if you're worried about having too many focus outlines in your interface.

Bug good first issue

Source

nickcolley

All 15 comments

As mentioned in the thread in the community, I think a great first step would be to make all hover states also apply on focus, that should get us pretty far already (and also improve the mobile experience!).

If anybody wants to tackle that, a quick search for ":hover" in src/ should give you a list of all the places!

mxstbr on 21 Nov 2018

Can I work on this?

reddysridhar53 on 1 Dec 2018

Yes please @reddysridhar53! :pray:

mxstbr on 1 Dec 2018

@mxstbr Can you help in understanding what is our final goal here? Having focus state for all actionable items or Accessibility ?

reddysridhar53 on 1 Dec 2018

👍1

Both!

mxstbr on 1 Dec 2018

May I take this?

code4cake on 3 Dec 2018

It'd be great if you split the work with @reddysridhar53!

mxstbr on 3 Dec 2018

👍1

Happy to review this work folks :)

@mxstbr if this goes well and we plan for more work like this, is there a way to compensate the people doing the work? Like with open collective etc

nickcolley on 3 Dec 2018

Hi @mxstbr , I was looking around for suitable suits to implement this and found https://github.com/WICG/focus-visible to be good. What do you think of us using this in the application?

reddysridhar53 on 4 Dec 2018

Hey @reddysridhar53 would you mind spitting the work between both of us or you rather tackle it alone ?

code4cake on 4 Dec 2018

Yeah that sounds reasonable!

mxstbr on 4 Dec 2018

Good question @nickcolley! There currently aren't plans to compensate contributors. I know accessibility is certainly undervalued in the industry and while we'd like to be part of the solution, it's just not something we're prepared to tackle at the moment...