Spectrum: [Mobile v1] Thread feeds

Created on 31 Jan 2018  路  14Comments  路  Source: withspectrum/spectrum

  • [x] Feature request

Splitting up #1803 into multiple sub-issues to track against

Once you're signed into Spectrum on mobile you should see your everything thread feed, and all the community and channels views will also mostly just show thread feeds, so we need to have some reusable thread components.

  • [x] Thread card

    • [x] Basic implementation (done by @ArturKlajnerok)

    • [x] Make sure all possible states are covered

    • [x] Fix padding and colors (@brianlovin)

    • [x] Overlay participant heads on top of each other (like we do on the website!)

  • [x] Subscribe to new threads
  • [x] Pull to refresh
  • [x] Infinite scrolling thread feed (#2333)
Feature good first issue

Most helpful comment

@ryota-murakami yeah that'd be great! I'm not sure if all of them are covered right now, ideally you take a look at the threadFeedCard component in the web version (src/components/threadFeedCard I think) and make sure all the states we render there are also covered in the mobile version.

All 14 comments

The ThreadCard kind of exists now, but it's not very nice and it's missing a ton of information:


Click to see old screenshot

screen shot 2018-04-11 at 14 06 21

PRs improving the styling and aligning the information presented with the web version would be much appreciated! :pray:

Hi @mxstbr, I can take a look at this one.

Thanks to @ArturKlajnerok in #2869 we're much closer already! 馃槏馃槏馃槏

Remaining todos:

  • [ ] Make sure all possible states are covered
  • [ ] Fix padding and colors (@brianlovin)
  • [ ] Overlay participant heads on top of each other (like we do on the website)

Hey @mxstbr 馃槃 ! Has someone taken the overlay participant heads task? I'd like to give it a go!

@TheMightyPenguin not yet, please do pick it up! :pray:

@mxstbr Great 馃槂 I'll start working on it then

Hi there @mxstbr! I just got into this (sorry for the delay, haven't had much time lately), currently running the app in an iOS emulator (running expo, api, and iOS emulator), and even tho I've seeded the database and can see the threads in the Web app, I get this in the mobile app:


Click to see screenshot

image

Is there any extra step I'm missing here to get it working? The problem seens to be in ThreadFeed.js and threadConnection being null, when I change tabs I can see the api generating logs tho

Thanks in advance!

@TheMightyPenguin that's very weird 馃 If you open the web app does it show any threads on your home view?

@mxstbr hello! i'm interested Make sure all possible states are covered task, could i take this?(i don't know all possible states though:sweat_smile:)

@ryota-murakami yeah that'd be great! I'm not sure if all of them are covered right now, ideally you take a look at the threadFeedCard component in the web version (src/components/threadFeedCard I think) and make sure all the states we render there are also covered in the mobile version.

Hey @mxstbr Yes I can see threads on my home view, I got it working tho by doing the following on the web app:

  1. Create a community
  2. Create a thread on that community

Then once I started the mobile app again I was able to see the threads :+1:
I'll start working on overlaying those heads 馃槃

_NOTE_: I had to clean iOS simulator cache with xcrun simctl erase all

@mxstbr i see, i'll compare it!

This is pretty much done apart from #3150 which will land soon, so I'll close this!

thanks, I'd like to help mobile ship followed by desktop馃檶馃摫

Was this page helpful?
0 / 5 - 0 ratings

Related issues

carloslfu picture carloslfu  路  3Comments

mxstbr picture mxstbr  路  3Comments

flaki picture flaki  路  5Comments

mxstbr picture mxstbr  路  5Comments

brianlovin picture brianlovin  路  5Comments