Spectre: Should mark v0.2.15 as major update

Created on 18 Aug 2017  Â·  16Comments  Â·  Source: picturepan2/spectre

Because of the root font-size changed, will may affect REM based design. People need to be notified.

Most helpful comment

Hi @picturepan2

Any better place for publishing the important change?

What about keep a changelog? ;)

BTW, great job. Thanks a lot.

All 16 comments

Also when is v0.2.16 coming out? I feel like there should be a hotfix cause I need the margin mixins to work. (See https://github.com/picturepan2/spectre/commit/e1889c840e060b51e4b551a3e30f142ce4b9ec2b). It's a pretty big bug.

Today or tomorrow. I am adding some other fixes to it. Thank you.

Yan Zhu


From: Mitchell Huang notifications@github.com
Sent: Saturday, August 19, 2017 9:10:16 AM
To: picturepan2/spectre
Cc: Subscribed
Subject: Re: [picturepan2/spectre] Should mark v0.2.15 as major update (#257)

Also when is v0.2.16 coming out? I feel like there should be a hotfix cause I need the margin mixins to work. (See e1889c8https://github.com/picturepan2/spectre/commit/e1889c840e060b51e4b551a3e30f142ce4b9ec2b). It's a pretty big bug.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHubhttps://github.com/picturepan2/spectre/issues/257#issuecomment-323490571, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AAHtsWFwtMr09w8IP9BhAaTVaSx_TO3Xks5sZjX3gaJpZM4O7bO2.

@ostoc Is it better to upgrade to 0.3.x branch?

@picturepan2 from my experience the new REM is not compatible with old version, and I spend few hours to change my all REM in the whole project. I am up for 0.3.x branch :)

@ostoc Sorry for that. I learn a lesson from this update.
Do you think there is a way to upgrade this kind of core things without making any trouble to others? Any better place for publishing the important change?

I am making the next release: v0.3.1.

@huangbong v0.3.1 is released https://github.com/picturepan2/spectre/releases/tag/v0.3.1. The utilities bug has been fixed.

@picturepan2 awesome! thanks! can you publish to npm? :)

I really should be maintaining my own version but I'm too lazy right now lol. Appreciate the fast turnaround!

@huangbong Done.

@picturepan2 FYI, the builds on cdnjs don't have the margin fix in. It's still padding. https://cdnjs.com/libraries/spectre.css

Hi @picturepan2

Any better place for publishing the important change?

What about keep a changelog? ;)

BTW, great job. Thanks a lot.

@dgdavid Thank you. I will look on that soon.

The dist/spectre.css file on the npm repo needs regenerating to include the margin/padding utility fix

@jooldesign Trying to fix it again.

@jooldesign Successfully updated with v0.3.2.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

roemhildtg picture roemhildtg  Â·  4Comments

kwstaskara picture kwstaskara  Â·  3Comments

CaiMiao picture CaiMiao  Â·  5Comments

alighasemzadeh picture alighasemzadeh  Â·  5Comments

elias-garcia picture elias-garcia  Â·  4Comments