Spacex-api: Difference in launchdates - SSO-A mission

[jeroenboumans]

Hi @jakewmeyer ,

I've noticed there is a difference in launch dates for mission SSO-A (flightnr 71):

...
"launch_date_unix": 1514764800,
"launch_date_utc": "2018-01-01T00:00:00.000Z",
"launch_date_local": "2017-12-31T16:00:00-08:00"
...

Since I don't have access to the mongodb anymore, could somebody fix this please?

Thanks! 👍

[jakewmeyer]

Looks like because the launch was delayed, the wiki has it as 2018 TBD currently. Looks like it just set the max precision wrong, it should be year instead of month.

Dates are different due to the time zone offset

Otherwise the date is correct

[jeroenboumans]

Thanks for the feedback jake! Could we add a property to the data informing us that the corresponding launch date currently is TBD (or is this the is_tentative property?) or making the launchdate more precise?

[jakewmeyer]

Well technically every upcoming launch is TBD to some extent 🤷‍♂️

I'm okay with adding the tbd boolean field if we want to. If the wiki launch manifest NET date contains TBD at all, I'll have it set as true.

[jeroenboumans]

Thanks Jake, appreciate it! :relaxed:

[jesusrp98]

Shouldn't be SSO-A the last 2018 mission to launch in 2018 now? Reading the upcoming launches list, I see that the launches that have a more concrete launch date are before the one that have a more vague launch date.

[jakewmeyer]

Order should be consistent with the order on the wiki. Pretty sure it'll launch the last week of November. If they change the order on the wiki, the API order will automatically update as well.

[jesusrp98]

OK that's great. Thanks!

[jakewmeyer]

@jeroenboumans do you want the tbd field? Or is it fine the way it is?

[jeroenboumans]

@jakewmeyer the TBD-field is very welcome from my point of view. For me, that field could tackle some logic on the frontend side of an application.

[jesusrp98]

What would be the difference between is_tentative & a hypothetical tbd field?

[jakewmeyer]

is_tentative was originally added for @philipengberg to help tell when a date doesn't have an exact time set for it. Trouble is, all the times are tentative up until the launch time. Pretty sure he is using the field in some way, but it doesn't mean TBD at all.

[philipengberg]

Correct, I use it to show NET Nov. 2018 fx, depending on the precision level.

[jesusrp98]

Using the TBD tag the same way used in the launch manifes would be a good idea. For example, when a launch is postponed indefinitely, like in this case.

[jeroenboumans]

@jakewmeyer @jesusrp98 I'd say leave the launch dates intact. End applications decide themselves whether they use the TBD property or not 👍

[jesusrp98]

Agree.

[jakewmeyer]

Field is added and live. What all should we consider to be TBD?

[jhpratt]

IMO if we don't know the exact NET day, regardless of whether the time is
unknown. The date is what people will likely be interested in in most
cases, anyways.

On Fri, Nov 23, 2018, 19:30 Jake Meyer <[email protected] wrote:

Field is added and live. What all should we consider to be TBD?

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/r-spacex/SpaceX-API/issues/184#issuecomment-441332835,
or mute the thread
https://github.com/notifications/unsubscribe-auth/ADA9M_1RBdcy2kAc-ldUbl2U7rf9BpCmks5uyJMLgaJpZM4Yn1M9
.

[jeroenboumans]

I agree with @jhpratt :)

[jakewmeyer]

Gotcha

Will consider dates like 2019 Jan, 2019, 2019 Q1, 2019 H1 as TBD

Dates like 2019 Feb 17, or 2019 Jan 8 04:57 won't be TBD

[jakewmeyer]

@philipengberg Also made a slight change to when is_tentative is set. If a launch has a time available, is_tentative will be false. Previously it was set as true until the moment of launch.

Felt like the field wasn't being used properly, but this should fix that.

[jeroenboumans]

awesome, thanks @jakewmeyer ! 👍

[philipengberg]

Sounds reasonable 👍