Spacex-api: Date inconsistency in /parts/caps

Created on 29 May 2018  路  4Comments  路  Source: r-spacex/SpaceX-API

Every capsule data returned by https://api.spacexdata.com/v2/parts/caps contains original_launch fields with some date. The problem is inconsistency format of it because every capsule except C113 contains only date or "TBD" which is ok.

C113 contains both date and time which causes some difficulties when I want to write smart method which filter capsules by passed date in argument, now it's a bit problem because I don't know if I should send original_launch with time or not.

Proposed solutions:

  • short: remove time from original_launch in C113 capsule
  • long: add time to every capsule

Part of the response with mentioned capsule:

{
  "capsule_serial":"C113",
  "capsule_id":"dragon1",
  "status":"active",
  "original_launch":"2017-08-14T16:31:00Z",
  "missions":[  
     "SpaceX CRS-12"
  ],
  "landings":1,
  "type":"Dragon 1.1",
  "details":"The last newly manufactured Dragon 1"
}

Thanx for your work!

Completed Data Fix

All 4 comments

All of them should have time, I'll make the changes shortly

Changes live. Changed all cases of "TBD" to null as well, which should be more appropriate.

Noticed this is also a problem with the core endpoint, so I'll make the same changes there

Looks good, change from TBD to null is also a good idea, now I can just pass parameter instead of doing a some sort of conversion.

Thanx!

Core fixes done 馃憤

Was this page helpful?
0 / 5 - 0 ratings

Related issues

CodyDSmith picture CodyDSmith  路  6Comments

markvital picture markvital  路  4Comments

499602D2 picture 499602D2  路  5Comments

esper-creative picture esper-creative  路  3Comments

MattoDeg picture MattoDeg  路  6Comments