Spacex-api: CORS not enabled?

Created on 8 Aug 2017  ·  5Comments  ·  Source: r-spacex/SpaceX-API

Did a change happen recently that disabled CORS? I was planning to use this data in a demo at a conference this week. The conference is unrelated to SpaceX, NASA or space in general... just a tech conference and thought it was a cool dataset.

But suddenly seeing errors related to CORS. The response headers look very different too... looking back through the commits I don't see anything that says CORS was disabled.

Most helpful comment

Damn... you responded too quick (I was just about to delete the issue I submitted).

My bad... stoopid error on my part. Thanks for making this available!

All 5 comments

Nope, still enabled! Here's the code.

I'm not sure where the issue is ─ Jake could help you with that. I know he started versioning it to prevent backward-incompatible changes on endpoints.

Damn... you responded too quick (I was just about to delete the issue I submitted).

My bad... stoopid error on my part. Thanks for making this available!

@andrewconnell Glad it's resolved. Haven't touched the CORS support since it was enabled a few weeks ago. What fixed it? Out of curiosity...

"thinner fingers"

IOW, fixed a stupid mistake on my part.

I'd love to help & contribute to the project, but I don't know Ruby :-/ Will keep an eye out for ways I can help...

No worries! If you have any suggestions or ideas, I'm sure we can find something for you to help out with. 👍

Was this page helpful?
0 / 5 - 0 ratings

Related issues

markvital picture markvital  ·  4Comments

jesusrp98 picture jesusrp98  ·  8Comments

markvital picture markvital  ·  3Comments

russelltwarwick picture russelltwarwick  ·  3Comments

samg11 picture samg11  ·  4Comments