Spaceship-prompt: Add pyenv snake emoji in venv

Created on 22 Jan 2018  路  6Comments  路  Source: denysdovhan/spaceship-prompt

Issue

add the same green snake emoji from pyenv in venv

Screenshot

captura

Environment

Spaceship version: 3.0.2
Zsh version: 5.2
Zsh framework: oh-my-zsh
Zsh plugin manager: None
Terminal emulator: Gnome-Terminal
Operating system: GNU/Linux Ubuntu 17.10

Relevant .zshrc


has-pr proposal

Most helpful comment

maybe pyenv can use this emoji 馃吙 and venv can stay with the moji of the snake? 馃悕

All 6 comments

Seems fair. Are you proposing we use same symbol for both venv and pyenv. Would be better if sections had different symbols.

maybe pyenv can use this emoji 馃吙 and venv can stay with the moji of the snake? 馃悕

Please, can anyone explain why we should change snake (the symbol of Python) to confusing 馃吙? As I know virtualenv can be used not only with Python. In another hand, pyenv is used only with Python.

Moreover, moving 馃悕 to indicate another section might cause confusions for users.

I'm against this change. This will lead to breaking changes in UX, which is user unfriendly.

Could you explain where virtualenv is used other than python? Just curious.

@denysdovhan Would you be open to a patch which adds a PYTHON_VENV_SYMBOL variable, defaulting to nothing? That way current behaviour would be preserved, but people could configure as they see fit.

Could you explain where virtualenv is used other than python?

@SanketDG I cannot explain it because I'm not working with this tool. However, my ex-coworker had told me about how he used virtualenv for Ruby development.

Anyway, I think I've explained the reason about UI-inconsistency pretty clear.


@JonyEpsilon, I'd open to add a SPACESHIP_VENV_SYMBOL option default to nothing or to the corresponding icon. That would be more consistent. In that case, @SanketDG will be able to switch icons between sections.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

AlecRust picture AlecRust  路  3Comments

vburojevic picture vburojevic  路  3Comments

ChadTaljaardt picture ChadTaljaardt  路  4Comments

gillesdemey picture gillesdemey  路  3Comments

olets picture olets  路  3Comments