Spaceship-prompt: Git status Update

[CMYKpixels]

I've just installed your theme for .oh-my-zsh, I run it throught Babun and I got this error message everytime I browse a folder wich is a git repo :
g/uwamp/www
➔ cd ~/.oh-my-zsh/themes
spaceship_git_satus:24: command not found: git_current_branch

[denysdovhan]

What is your environment?

[denysdovhan]

I've made a small research: since you use Babun, I suppose you are on Windows, right? So, It's possible you just don't have git_current_branch command in your environment just.

This is where this functions is defined in oh-my-zsh. Please, check you installation of oh-my-zsh.

[denysdovhan]

Did that help you?

[CMYKpixels]

I've just read your answer, thanks for being quick ! I should be able to test it tonight. I'll let you know !

[denysdovhan]

Okay, will wait.

[CMYKpixels]

And I run Win10. Babun is a shell that expand the classic windows CMD.

[denysdovhan]

So it's the root of the problem. Better to use this with Unix-based systems.

[nWidart]

I'm having the same issue on a Mac. I've just updated zsh, and it's still throwing the error somehow.

I'm using version 5.3.1

[denysdovhan]

@nWidart try to update to the latest version of Spaceship. There's not spaceship_git_status function since v2.0.0.

[nWidart]

Hm I just downloaded the zip file of the repository like 15min ago.
I used the manual way using https://raw.githubusercontent.com/denysdovhan/spaceship-zsh-theme/master/spaceship.zsh , which is on master branch so should be up to date ?

Indeed, I just downloaded via the 2.0 release page, and getting the same errors.

[nWidart]

The 2 errors I'm getting specifically:

spaceship_git_branch:5: command not found: git_current_branch
spaceship_git_status:16: command not found: git_prompt_status

[denysdovhan]

@nWidart sorry, I misunderstood you.

Notice that Spaceship depends on Oh-My-Zsh. Have you installed OMZ?

[nWidart]

Hm interesting, I though I did, because I have zsh installed. But it now looks like it's now the same thing.

I'm using YADR dotfiles which installs zsh, not sure if I can just run the oh-my-zsh installer w/o issues. 🤔

[salmanulfarzy]

Looks like YADR installas prezto. Not sure about how much of YADR conf depends on prezto.

[nWidart]

Oh okay, and prezto & ohmyzsh can't be installed together?

[salmanulfarzy]

Prezto was actually a fork of OMZ and they diverged considerably. You can't have both of them together.

spaceship-theme requires OMZ for some features and it doesn't currently support prezto.

[denysdovhan]

It forces me to think about making Spaceship more standalone. OMZ has nice utils, however we should not force our users to use that.

[nWidart]

@sfarzy Damn that's too bad. I wasn't aware Prezto is a fork of OMZ. 😲

In would be nice indeed to allow both. Sadly I won't be able to use this nice theme b/c of this.

However it depends on how many people are in the same boat as me, I might just be an edge case.

Maybe those 2 functions could be brought onto this theme itself ? It depends how many other things depends on OMZ I guess.

[salmanulfarzy]

I think the major (only?) dependency with OMZ would be the git indicators. @denysdovhan It would be great if spaceship-theme is independent of frameworks.

[nWidart]

Hello,

No news on supporting prezto 😄 ?

[salmanulfarzy]

We're working on it and will drop OMZ with #147 @nWidart 😊. I hope spaceship wil work with prezto after that.

[nWidart]

Nice! That's good news!

[charles-passille-smartnets]

@CMYKpixels

In spaceship.zsh-theme :499
You can change git_current_branch() to current_branch() for babun oh-my-zsh.

Also to remove the extra line, in your .zshrc file, add this unsetopt PROMPT_SP

There will still be a problem with the font (for me at least), I'm working on it...