Sp-dev-fx-controls-react: Question: new components - folders list and folder picker

Created on 23 Jan 2020  路  4Comments  路  Source: pnp/sp-dev-fx-controls-react

Category

[x] Enhancement

[ ] Bug

[x] Question

Expected / Desired Behavior / Question

Hi, I recently created a reusable folder picker control that I should be able to port to this repository. Should I submit a PR?

Sample picker control:

image

Clicking the icon to select a folder on the right side of the control opens a panel to select a folder
image

When an item is selected, it renders a link to that folder

image

The inner control (folders list + filter + folder creation) is also reusable as it works independently from the picker and side panel,

image

Sample code for folder picker:

<FolderPicker webPartContext={this.props.webPartContext}
rootFolder={this.props.selectedFolder}
defaultFolder={this.state.defaultFormFolder}
onSelect={this._onDefaultFolderSelect.bind(this)}
label='Upload folder'
canCreateFolders={true}>
</FolderPicker>

Sample code for folders list

<FoldersList
webPartContext={this.props.webPartContext}
rootFolder={this.props.rootFolder}
defaultFolder={this.state.selectedFolder}
onSelect={this._onFolderSelect}
canCreateFolders={this.props.canCreateFolders}
/>
question

Most helpful comment

Hi @joelfmrodrigues!
Feel free to add it!
If it is needed once, it could be needed for others!

All 4 comments

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

Hi @joelfmrodrigues!
Feel free to add it!
If it is needed once, it could be needed for others!

@AJIXuMuK took me long to be able to find some time for this, but the PR for the first control is now submitted.
This is a folder explorer which I have now used in a couple of projects and is also used by the folder picker control mentioned above.
I will try to submit PR for the other control before the end of the week 馃槉

Awesome job @joelfmrodrigues!

I have merged your PR!

Thank you for the contribution!

Was this page helpful?
0 / 5 - 0 ratings