Sp-dev-docs: SPFx Teams Tab - code sample contains a unused parameter

[baywet]

https://docs.microsoft.com/en-us/sharepoint/dev/spfx/web-parts/get-started/using-web-part-as-ms-teams-tab#updating-code-to-be-aware-of-the-microsoft-teams-context
Item #3
The reject parameter is never used, either removed it, use it or prefix it with _
Happy to PR away if you provide guidance

---

Document Details

⚠ Do not edit this section. It is required for docs.microsoft.com ➟ GitHub issue linking.

• ID: 4521ae6c-2ac6-8898-4731-0a5a50349d76
• Version Independent ID: 49edacf9-9538-079b-24ab-3ce17017ba77
• Content: Building Microsoft Teams tab using SharePoint Framework - Tutorial
• Content Source: docs/spfx/web-parts/get-started/using-web-part-as-ms-teams-tab.md
• Product: sharepoint
• GitHub Login: @spdevdocs
• Microsoft Alias: spdevdocs

[msft-github-bot]

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

[msft-github-bot]

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 7 days. It will be closed if no further activity occurs within next 7 days of this comment. Thank you for your contributions to SharePoint Developer activities.

[baywet]

@andrewconnell when you tag it with needs author feedback, do you mean the issue author or the documentation author?

[andrewconnell]

I'm not sure why I added that specific tag in this instance... my bad...

But to answer your question @baywet - the Needs: AuthorFeedback label means the OP needs to chime in. There's no relation to the underlying author of the doc.

If the OP doesn't respond within 7d, the bot tags it as stale and politely reminds we're waiting for feedback. If there's no response for another 7d by the OP, the issue is closed automatically. If the OP does reply in that 14d window, the bot removes the label & replaces it with Needs:Attention highlighting it.

[baywet]

thanks for the explanation! Minor feedback: I don't know if I missed anything but it'd be interesting to have the tagging/triaging/resolving process for issues documented somewhere, like in the wiki or so. This way people know what to expect/do and the bot could point to that doc when posting messages.

[andrewconnell]

Yup... _working on it_... this process just got rolled out to this repo last week and we're still getting our arms around it. It's a responsibility I've taken on... got a doc, but think it's better to roll out one that doesn't have a lot of holes in it :)

[andrewconnell]

[msft-github-bot]

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues