Sp-dev-docs: 🐞TS type declaration packages should be in devDependencies, not dependencies

Created on 18 Jul 2018 · 4Comments · Source: SharePoint/sp-dev-docs

Expected or Desired Behavior

NPM packages that are not needed for production & only for development, such as TypeScript type declaration files, should only be in the devDependencies section of package.json within a Node.js project. This means the following two packages should be in devDependencies:

@types/webpack-env
@types/es6-promise

Observed Behavior

The two packages listed above are in the dependencies section of package.json

Steps to Reproduce

Create a SPFx project with v1.5.1 and look at the package.json file

tooling fixed-next-drop tracked bug-confirmed

Source

andrewconnell

Most helpful comment

Thanks for the feedback. This is not urgent but we have added it to our backlog.

GrahamMcMynn on 19 Jul 2018

👍2

All 4 comments

Thanks for the feedback. This is not urgent but we have added it to our backlog.

GrahamMcMynn on 19 Jul 2018

👍2

Yup... not urgent as it doesn't impact anything, just making things more correct. Accept PR's to the generator and I'll submit the fix ;)

BTW... same comment for React-based projects too. The two React @types/* packages should also be moved => devDependencies

andrewconnell on 21 Jul 2018

The fix will be included into the next @microsoft/generator-sharepoint version.

johnguy0 on 30 Jan 2020

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues