Sp-dev-docs: Error when bundling solution targeting on-prem

[waldekmastykarz]

Category

• [ ] Question
• [ ] Typo
• [x] Bug
• [ ] Additional article idea

Expected or Desired Behavior

Be able to bundle newly created project.

Observed Behavior

When running gulp bundle on a newly created project, scaffolded using generator v1.4.0, targeting on-prem, you get the following error:

[13:04:59] Error - typescript - <undefined path>(0,0): error TS2688: Cannot find type definition file for 'es6-promise'.

Steps to Reproduce

• scaffold new project using generator v1.4.0
• baseline: _SharePoint 2016 onwards, including SharePoint Online_
• other options default values
• no JavaScript framework (the same error occurs when choosing React as framework)
• run gulp bundle 💥

[iclanton]

@nickpape-msft - can you take a look?

[joaoferreira]

Had the same issue, I was able to bundle the solution after installing the type definitions for es6-promise again.
npm install --save @types/es6-promise

[nickpape]

Looks like we have a dependency that is missing for on-prem. @joaoferreira's workaround is the correct solution. We will update the generator with this missing package.

[nickpape]

@waldekmastykarz , are you using NPM or a different package manager to do installations? Which version of NPM are you using? Could you manually check the node_modules/@types/ folder and see if es6-promise is there?

It looks like various framework packages (including [email protected]) should be bringing @types/es6-promise as an indirect dependency, which should get resolved by your tsconfig.json. If you have a consistent repro, could you try just running another npm install after the generator is complete just to ensure all dependencies are installed?

Or even better, could you run npm list @types/es6-promise on a repro of this issue? Again, I wasn't able to repro this using [email protected]. I am trying now with [email protected].

[waldekmastykarz]

I've just checked it and it seems like the issue occurs only on node v8 and npm v5. On node v6 with npm v4 everything works just fine. The odd thing is, that in both cases the output of the npm ls @types/es6-promise command is the same:

├─┬ @microsoft/[email protected]
│ ├─┬ @microsoft/[email protected]
│ │ └── @types/[email protected]
│ └─┬ @microsoft/[email protected]
│   └── @types/[email protected]
├─┬ @microsoft/[email protected]
│ ├─┬ @microsoft/[email protected]
│ │ └── @types/[email protected]
│ ├─┬ @microsoft/[email protected]
│ │ └── @types/[email protected]
│ ├─┬ @microsoft/[email protected]
│ │ └── @types/[email protected]
│ ├─┬ @microsoft/[email protected]
│ │ └── @types/[email protected]
│ └── @types/[email protected]
└─┬ @microsoft/[email protected]
  ├─┬ @microsoft/[email protected]
  │ ├─┬ @microsoft/[email protected]
  │ │ └── @types/[email protected]
  │ └── @types/[email protected]
  ├─┬ @microsoft/[email protected]
  │ └── @types/[email protected]
  └── @types/[email protected]

Since node v8 is not officially supported at the moment, we could close this issue, but perhaps it would be helpful for you guys to track this internally when fixing support for node v8, which being LTS should be supported.

[nickpape]

Thanks @waldekmastykarz , we will continue to track the issue internally.

[nickpape]

@waldekmastykarz this should be working properly now.

[msft-github-bot]

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues