Sp-dev-docs: Make host name configurable / change "localhost" occurances in SPFx modules

Created on 14 Mar 2017 · 8Comments · Source: SharePoint/sp-dev-docs

Expected or Desired Behavior

I tried to deploy the workbench to a Docker container on Azure but it fails to work properly. Technically it was running correctly but I spotted some issues in the SharePoint Framework.
The scenario for this is to allow customer to preview web parts and test the behaviour before the web part will be deployed to any tenant.
In addition this scenario allows enhance and improve cross browser testing as well es automated front end testing
It would be great to make hostname configurable vie serve.json.

Observed Behavior

Currently the workbench cannot run on any other host name than localhost. This is because inside the framework the "localhost" string is exposed in many different source files in the node modules. Overall the treatment of the host name is inconsistent in many ways.
serve.json allows to set ports and an initial start page, even if another host name is defined there the all requests will be redirected to localhost.

Source

StfBauer

All 8 comments

@iclanton - FYI

patmill on 16 Mar 2017

Sounds like a good idea to me. I'll create a work item for it.

iclanton on 16 Mar 2017

👍1

Fixed.

amishra0909 on 10 May 2017

👎1

@amishra0909 Is this fixed version currently available?

StfBauer on 31 May 2017

"Fixed" is not a valid reason to close an issue.
@iclanton Can you please provide some more information because @amishra0909 won't respond for some reason?

Thank you in advance.

StfBauer on 4 Jun 2017

Hi @StfBauer, @amishra0909 is not from Microsoft, so will now re-open this to be able to follow up on the actual request. Actual request does make lot of sense.

VesaJuvonen on 4 Jun 2017

👍1

Thank you @VesaJuvonen !

StfBauer on 5 Jun 2017

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues