Source-build: 5.0.4 is missing DotnetTools

[tmds]

On my Fedora 32 machine, I have dotnet-sdk-5.0 at 5.0.102, and on my Fedora 33 machine I have it at 5.0.104.

The first includes the DotnetTools folder, and for the second it is missing.

The tools folder provides the dotnet-dev-certs tool.

The Microsoft 5.0.104 tar.gz includes the folder.

cc @omajid @crummel @MichaelSimons @dseefeld

[dotnet-issue-labeler[bot]]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[tmds]

I've updated the package on my Fedora 32 machine, now DotnetTools is also gone.

On our RHEL 8 builds of 5.0.104, the folder is present. :open_mouth:

[tmds]

Some parts of the build logs.
RHEL8 (working):

  Copying file from "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/dotnet-aspnetcore.e882394a7bb38930da748291fe2c2ceaa6a80588/artifacts/packages/Release/NonShipping/dotnet-dev-certs.5.0.4-servicing.21118.15.nupkg" to "/builddir/build/BUILD/dotnet-v5.0.104-SDK/artifacts/obj/x64/Release/blob-feed/packages/dotnet-dev-certs.5.0.4-servicing.21118.15.nupkg".
    -> dotnet-dev-certs 5.0.4-servicing.21118.15
           Creating directory "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/dotnet-sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.2-servicing.20613.2/tools/net5.0/any".
           Creating directory "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/dotnet-sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.2-servicing.20613.2/tools/net5.0/any".
           Creating directory "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/dotnet-sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.2-servicing.20613.2/tools/net5.0/any".
           Creating directory "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/dotnet-sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.2-servicing.20613.2/tools/net5.0/any".
           Copying file from "/builddir/build/BUILD/dotnet-v5.0.104-SDK/.dotnet/sdk/5.0.102/DotnetTools/dotnet-dev-certs/5.0.2-servicing.20613.2/tools/net5.0/any/dotnet-dev-certs.dll" to "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/dotnet-sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.2-servicing.20613.2/tools/net5.0/any/dotnet-dev-certs.dll".
           Copying file from "/builddir/build/BUILD/dotnet-v5.0.104-SDK/.dotnet/sdk/5.0.102/DotnetTools/dotnet-dev-certs/5.0.2-servicing.20613.2/tools/net5.0/any/DotnetToolSettings.xml" to "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/dotnet-sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.2-servicing.20613.2/tools/net5.0/any/DotnetToolSettings.xml".
           Copying file from "/builddir/build/BUILD/dotnet-v5.0.104-SDK/.dotnet/sdk/5.0.102/DotnetTools/dotnet-dev-certs/5.0.2-servicing.20613.2/tools/net5.0/any/dotnet-dev-certs.runtimeconfig.json" to "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/dotnet-sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.2-servicing.20613.2/tools/net5.0/any/dotnet-dev-certs.runtimeconfig.json".
           Copying file from "/builddir/build/BUILD/dotnet-v5.0.104-SDK/.dotnet/sdk/5.0.102/DotnetTools/dotnet-dev-certs/5.0.2-servicing.20613.2/tools/net5.0/any/dotnet-dev-certs.deps.json" to "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/dotnet-sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.2-servicing.20613.2/tools/net5.0/any/dotnet-dev-certs.deps.json".

Fedora (not working):

  Copying file from "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/aspnetcore.e882394a7bb38930da748291fe2c2ceaa6a80588/artifacts/packages/Release/NonShipping/dotnet-dev-certs.5.0.4-servicing.21118.15.nupkg" to "/builddir/build/BUILD/dotnet-v5.0.104-SDK/artifacts/obj/x64/Release/blob-feed/packages/dotnet-dev-certs.5.0.4-servicing.21118.15.nupkg".
    -> dotnet-dev-certs 5.0.4-servicing.21118.15
           Creating directory "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.3-servicing.21073.3/tools/net5.0/any".
           Creating directory "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.3-servicing.21073.3/tools/net5.0/any".
           Creating directory "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.3-servicing.21073.3/tools/net5.0/any".
           Creating directory "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.3-servicing.21073.3/tools/net5.0/any".
           Copying file from "/builddir/build/BUILD/dotnet-v5.0.104-SDK/previously-built-dotnet/sdk/5.0.103/DotnetTools/dotnet-dev-certs/5.0.3-servicing.21073.3/tools/net5.0/any/DotnetToolSettings.xml" to "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.3-servicing.21073.3/tools/net5.0/any/DotnetToolSettings.xml".
           Copying file from "/builddir/build/BUILD/dotnet-v5.0.104-SDK/previously-built-dotnet/sdk/5.0.103/DotnetTools/dotnet-dev-certs/5.0.3-servicing.21073.3/tools/net5.0/any/dotnet-dev-certs.dll" to "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.3-servicing.21073.3/tools/net5.0/any/dotnet-dev-certs.dll".
           Copying file from "/builddir/build/BUILD/dotnet-v5.0.104-SDK/previously-built-dotnet/sdk/5.0.103/DotnetTools/dotnet-dev-certs/5.0.3-servicing.21073.3/tools/net5.0/any/dotnet-dev-certs.deps.json" to "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.3-servicing.21073.3/tools/net5.0/any/dotnet-dev-certs.deps.json".
           Copying file from "/builddir/build/BUILD/dotnet-v5.0.104-SDK/previously-built-dotnet/sdk/5.0.103/DotnetTools/dotnet-dev-certs/5.0.3-servicing.21073.3/tools/net5.0/any/dotnet-dev-certs.runtimeconfig.json" to "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.3-servicing.21073.3/tools/net5.0/any/dotnet-dev-certs.runtimeconfig.json".
           Copying file from "/builddir/build/BUILD/dotnet-v5.0.104-SDK/previously-built-dotnet/sdk/5.0.103/DotnetTools/dotnet-dev-certs/5.0.3-servicing.21073.3/tools/net5.0/any/System.Security.Cryptography.Cng.dll" to "/builddir/build/BUILD/dotnet-v5.0.104-SDK/src/sdk.2932b586ae1ebf28415df80e0bf96d8015f2c192/artifacts/bin/redist/Release/dotnet/sdk/5.0.104-servicing.21118.26/DotnetTools/dotnet-dev-certs/5.0.3-servicing.21073.3/tools/net5.0/any/System.Security.Cryptography.Cng.dll".

A notable difference is that on Fedora we're using a previously-built-dotnet.

Fedora build log is at https://kojipkgs.fedoraproject.org//packages/dotnet5.0/5.0.104/1.fc33/data/logs/x86_64/build.log.

[crummel]

I'm suspecting a diff between the tarballs and the public release, taking a quick look.

[crummel]

Yes, this is due to a patch diff concerning a build variable that was removed in installer. I patched the variable back in but I included too much in the exclusion. I'll fix this in 5.0.5.

[tmds]

@crummel have you had a chance to look at this already for the upcoming 5.0.5?

[tmds]

ping @crummel

[omajid]

5.0.5 has them again. Thanks for fixing this, @crummel!

[tmds]

@crummel @omajid what PR fixed this?

[omajid]

Just a guess: https://github.com/dotnet/source-build/pull/2117/files#diff-2d2d3fdbeaa1a1dd3aacd0cf3edbdc7a1afa655b743e00ce8fde369720f26e34