Sortable: Chrome 62 (new version) - pointercancel event triggered wrongly

Created on 23 Oct 2017 · 22Comments · Source: SortableJS/Sortable

On new chrome version 62 released a week ago, drag/drop stopped working for me,

the below line, is whats causing it:

_on(ownerDocument, 'pointercancel', _this._onDrop);

_onDrop is triggered although drop hasn't yet occurred.
Removing this line causes the drag/drop to start working again.

Source

bhecht2

👍17 ❤1

Most helpful comment

+ [email protected]

RubaXa on 6 Nov 2017

👍3

All 22 comments

I owe you a beer or small pony, dude. Thanks!

rlandrigan on 23 Oct 2017

Thanks for finding this - I've been trying to figure out how everything broke on my side.

shawnwallace on 24 Oct 2017

Would this be the change causing it? (edit: turns out not to be it, see below) https://chromium.googlesource.com/chromium/src/+/a11800062c65e2e1d305ab18402c48a3833dd9eb

Is this a chrome problem or a Sortable.js oversight / misinterpretation of the event?

rikkertkoppes on 26 Oct 2017

No. This is the change causing this. Technically browsers should send pointercancel when they interrupt handling the input stream and page would not receive any more events for that pointer. We discussed this in the pointerevent working group and this github issue at length.
I'm wondering why you would need to call onDrop handler on pointercancel event. What scenario were you trying to address there?

NavidZ on 26 Oct 2017

👍2

It appears to be this:
https://chromium.googlesource.com/chromium/src/+/656f9b939150e9a40553757cea46d385bcb423d9

I'm working with the author(s) on it.

shawnwallace on 26 Oct 2017

Try passive-branch

RubaXa on 27 Oct 2017

Passive mode seems to work without issue.

shawnwallace on 27 Oct 2017

Is there a plan to merge the passive branch to the master? @RubaXa do you have an estimate of how many websites are broken and do not automatically use the latest version of the Sortable library? Basically the ones that don't get fixed with your fix.

NavidZ on 27 Oct 2017

And so, that now into master:

Merged passive-branch
Add low-level option supportPointer: https://github.com/RubaXa/Sortable/commit/d1e6026cff304c0395ed808e251ec93e9b2ebe33

// Global disabling support
Sortable.supportPointer = false;

// Or
Sortable.create(el, {
  supportPointer: false,
});

If all right, then I ready to publish a new version.

RubaXa on 28 Oct 2017

❤1

@RubaXa When are you going to release the new version ?

mistyjae on 30 Oct 2017

@RubaXa, I'm a little confused by the name of the low level option. So for the people to get the library working they need to disable pointerevent support in the library? Is that correct or am I misunderstanding this?

NavidZ on 30 Oct 2017

@NavidZ I can not reproduce this problem, but if someone there is the bug, he can use this option.

RubaXa on 30 Oct 2017

Yo! My project was using 1.5.0, upgraded to 1.6.1 and everything works as expected again.

tmm on 31 Oct 2017

👍1

@RubaXa , any idea when you will publish a new version (cdn + npm) with the corresponding changes?

David-Desmaisons on 1 Nov 2017

👍1

@dandv at the weekend I try to check and publish a new version.
If someone more can do this (especially Edge and Android), it would be super!

RubaXa on 1 Nov 2017

I believe I found the actual problem/solution. The problem was fixed in this commit. So anybody who is using any version newer than that should not face any issue. So I assume anybody whoever was using the older version than that was seeing this issue. So I guess the passive pointer wouldn't be needed after all.

NavidZ on 1 Nov 2017

👍1

i update sortable to new version and add option supportPointer: false to my code