Sops: make_download_page.sh can fail to generate output

[coretemp]

https://github.com/mozilla/sops/blob/master/make_download_page.sh can fail to generate output, because the aws s3 can fail.

I don't really see what the point of automation is, if you do it incorrectly.

[autrilla]

We welcome contributions to fix this issue, if you're smarter than us and can do it correctly 😉 .

Why are you generating this anyway?

[coretemp]

You want to use a combination of exponential backoff, a portable version of timeout (man timeout), make sure that every command has an exit status of 0 by using &&, you need to check for pipe failure and you probably want to use printf instead of echo, and finally you want to use include/exclude filters to save on bandwidth and increase performance (you can even get rid of the grep then simplifying the problem).

I am fairly sure I could rewrite this whole thing to use only a single invocation of awk.

I would say whoever wrote this did almost everything wrong. I would never publish something like that and connect my name to it. You can take a guess as to whether I am smarter than you.

[autrilla]

We welcome contributions to fix this issue, if you're smarter than us and can do it correctly 😉 .

[jvehent]

I don't know if you're smarter, but you're certainly a pompous ass. We
welcome contribution from people interested in helping, not from people
looking for self agrandissement.

This shell script is such an unimportant part of the Sops project that I
propose to close this issue as wontfix.

On Wed, Nov 14, 2018, 09:25 coretemp <[email protected] wrote:

You want to use a combination of exponential backoff, a portable version
of timeout (man timeout), make sure that every commands has an exit status
of 0 by using &&, you need to check for pipe failure and you probably want
to use printf instead of echo, and finally you want to use include/exclude
filters to save on bandwidth and increase performance (you can even get rid
of the grep then simplifying the problem).

I am fairly sure I could rewrite this whole thing to use only a single
invocation of awk.

I would say whoever wrote this did almost everything wrong. I would never
publish something like that and connect my name to it. You can take a guess
as to whether I am smarter than you.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/mozilla/sops/issues/394#issuecomment-438746610, or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAZXgW4-jVWSaZ8OASKF3e7rI__RGWFnks5uvFIggaJpZM4YdRTr
.

[autrilla]

Works for me 😄