Sonataadminbundle: Test AdminMakerTest broken

Created on 6 May 2020  路  3Comments  路  Source: sonata-project/SonataAdminBundle

After update symfony/maker-bundle v1.14.6 to v1.16.0 the test of AdminMaker was broken because changed API of Symfony\Bundle\MakerBundle\FileManager in https://github.com/symfony/maker-bundle/pull/559.

Failed build:
https://travis-ci.org/github/sonata-project/SonataAdminBundle/jobs/683856722

bug

All 3 comments

I confirm the issue @peter-gribanov.
Even, the dependency isn't part of the common requirements (it's listed in require-dev).
The API change is expected since that class is marked as internal.

I remember giving it a try using MakerTestCase, here are some examples if someone wants to try.

I made a quick fix here: https://github.com/sonata-project/SonataAdminBundle/pull/6087

But re-writing the test without using internal classes could be great.

Was this page helpful?
0 / 5 - 0 ratings