Sonarr: Preferred Words overrule season pack preference
Describe the bug
A bonus to a specific release group prevents Sonarr from grabbing season packs without such bonus since it will first grab the single episode (on btn) and then reject the pack.
A fix is a bit of a challenge since Preferred Words overrules Protocol too, so we can't just move episode count up.
Taloth
All 4 comments
Is this really a bug? It may be unexpected in some cases, but it still makes sense in the end and we can't re-order things based on there maybe being a season pack.
markus101
on 4 Feb 2020
The pack likely contains the preferred episode too, it's simply not in the pack name coz it usually contains multiple groups.
It really depends on what's more important: having all episodes, or satisfy the preferred words. in this case the user is stuck with 1 episode and missing the rest. The only workaround is to add a regex to give season packs more priority in preferred words.
The simplest approach is to prefer a season pack over preferred words, but based on pack, not episode count (otherwise dual episodes would get preference).
The ultimate way would be to find the best season pack (according to the rules) _and_ find the right combination of single episodes (according to the rules). And then decide between the two best options to see which best satisfies the request that way a combination that gets all episodes automatically gets preferred over one with less episodes, regardless of score.
That's of course a lot more work but solves a number of other issues.
Taloth
on 4 Feb 2020
Trash has some a preferred word schema for season packs as a good workaround
https://trash-guides.info/Sonarr/V3/Sonarr-Release-Profile-RegEx/#optional-preferred-preferences
bakerboy448
on 18 Nov 2020
The simplest approach is to prefer a season pack over preferred words, but based on pack
This is easy, pull out:
https://github.com/Sonarr/Sonarr/blob/850552bf1769e663d6001a77b7cf76f88dad00a4/src/NzbDrone.Core/DecisionEngine/DownloadDecisionComparer.cs#L108-L114
To a function called before preferred word score, but then you end up preferring season packs over protocol as well, which seems unexpected. We don't really have a way to prefer season packs over preferred words, but also below protocol. So do we make it a option?
markus101
on 18 Nov 2020
Related issues
markus101
路
4Comments
pimlie
路
4Comments
cjamesdesigner
路
3Comments
daviddavo
路
4Comments
WildOrangutan
路
4Comments
Most helpful comment
The pack likely contains the preferred episode too, it's simply not in the pack name coz it usually contains multiple groups.
It really depends on what's more important: having all episodes, or satisfy the preferred words. in this case the user is stuck with 1 episode and missing the rest. The only workaround is to add a regex to give season packs more priority in preferred words.
The simplest approach is to prefer a season pack over preferred words, but based on pack, not episode count (otherwise dual episodes would get preference).
The ultimate way would be to find the best season pack (according to the rules) _and_ find the right combination of single episodes (according to the rules). And then decide between the two best options to see which best satisfies the request that way a combination that gets all episodes automatically gets preferred over one with less episodes, regardless of score.
That's of course a lot more work but solves a number of other issues.