Solidity: doc solidity-by-example.rst is out of date

Created on 16 Mar 2018  路  17Comments  路  Source: ethereum/solidity

the first example is still used pragma solidity ^0.4.16 as the other examples in the same doc already update to ^0.4.21;
and in this example, it still have out of date comment for require

            // If the argument of `require` evaluates to `false`,
            // it terminates and reverts all changes to
            // the state and to Ether balances. It is often
            // a good idea to use this if functions are
            // called incorrectly. But watch out, this
            // will currently also consume all provided gas
            // (this is planned to change in the future).
            require(
                (msg.sender == chairperson) &&
                !voters[voter].voted &&
                (voters[voter].weight == 0)
            );
documentation good first issue help wanted

Most helpful comment

@gitcoinbot it has been merged already.

All 17 comments

We try to always use the oldest version of Solidity that is still able to compile the code. Thanks for telling us about the outdated comment!

__This issue now has a funding of 0.16 ETH (60.86 USD @ $380.4/ETH) attached to it.__

  • If you would like to work on this issue you can claim it here.
  • If you've completed this issue and want to claim the bounty you can do so here
  • Questions? Get help on the Gitcoin Slack
  • $2512.16 more Funded OSS Work Available at: https://gitcoin.co/explorer

__Work has been started on the 0.16 ETH (101.45 USD @ $634.05/ETH) funding by__:

  1. @netrunnerX

__Please work together__ and coordinate delivery of the issue scope. Gitcoin doesn't know enough about everyones skillsets / free time to say who should work on what, but we trust that the community is smart and well-intentioned enough to work together. As a general rule; if you start work first, youll be at the top of the above list ^^, and should have 'dibs' as long as you follow through.

On the above list? Please leave a comment to let the funder (@vs77bb) and the other parties involved what you're working, with respect to this issue and your plans to resolve it. If you don't leave a comment, the funder may expire your submission at their discretion.

Hello, i'm going to work on this.

@netrunnerX are you still working on this issue?

@gitcoinbot it has been merged already.

@axic. :wave: thanks for the atMention, but you need to install @gitcoinbot on this repo for me to be able to respond. More details in the documentation.

:v:
@gitcoinbot

@netrunnerX are you still working on this issue?

So, what are the security implications of installing @gitcoinbot on this repo?

@chriseth. :wave: thanks for the atMention, but you need to install @gitcoinbot on this repo for me to be able to respond. More details in the documentation.

:v:
@gitcoinbot

@netrunnerX can you claim the bounty without us installing the app on the repo?

@chriseth I wish, the problem is that I must pay gas to submit work on Gitcoin and I have 0 eth 馃槄 . I have to find a way to buy some eth.

Hi @chriseth @netrunnerX sorry for the delay on our side here, and for Gitcoin Bot running wild. Sincerely apologize and will clean up Gitcoin Bot accordingly. cc @owocki

Yes, @netrunnerX can claim without you installing the app.

@netrunnerX - feel free to make a submission to the Gitcoin Faucet, which will distribute you enough ETH to submit work. From there, we will pay out for this bounty!

Hi @vs77bb ,

I'm trying to submit a request to Gitcoin Faucet, but it returns an error:
"The submitted github profile shows a pending faucet distribution."

The weird thing is that i haven't submitted a previous request. The only thing I did before was check the URL before going out of home.
Is there a way to see if I really have a pending distribution?

Thank you!

@netrunnerX Just DM'd you on Gitcoin slack for your MetaMask details. I'll send over to you soon!

__Work for 0.16 ETH (101.45 USD @ $634.05/ETH) has been submitted by__:

  1. @netrunnerX

Submitters, please leave a comment to let the funder (@vs77bb) (and the other parties involved) that you've submitted you work. If you don't leave a comment, the funder may expire your submission at their discretion.

__The funding of 0.16 ETH (101.45 USD @ $634.05/ETH) attached to this issue has been approved & issued to @netrunnerX.__

Was this page helpful?
0 / 5 - 0 ratings

Related issues

AnthonyAkentiev picture AnthonyAkentiev  路  3Comments

chriseth picture chriseth  路  3Comments

madvas picture madvas  路  3Comments

axic picture axic  路  3Comments

chriseth picture chriseth  路  4Comments