Solidity: Heisenbug - sigsegv when using --ast

Created on 13 Mar 2018  Â·  28Comments  Â·  Source: ethereum/solidity

Solidity has had a bug for a long time on MacOS that only occurs in release builds and is related to the move constructor or move-assignment operator of std::map. It might be related to some versions of the standard library only and migth also occur only for certain versions of the compiler. This bug report is one instance of it.

Original description:

Just about every contract I have tried with the --ast option has given sigsegv.

$ solc --ast node_modules/zeppelin-solidity/contracts/math/SafeMath.sol 
node_modules/zeppelin-solidity/contracts/math/SafeMath.sol:9:3: Warning: Function state mutability can be restricted to pure
  function mul(uint256 a, uint256 b) internal constant returns (uint256) {
  ^
Spanning multiple lines.
node_modules/zeppelin-solidity/contracts/math/SafeMath.sol:15:3: Warning: Function state mutability can be restricted to pure
  function div(uint256 a, uint256 b) internal constant returns (uint256) {
  ^
Spanning multiple lines.
node_modules/zeppelin-solidity/contracts/math/SafeMath.sol:22:3: Warning: Function state mutability can be restricted to pure
  function sub(uint256 a, uint256 b) internal constant returns (uint256) {
  ^
Spanning multiple lines.
node_modules/zeppelin-solidity/contracts/math/SafeMath.sol:27:3: Warning: Function state mutability can be restricted to pure
  function add(uint256 a, uint256 b) internal constant returns (uint256) {
  ^
Spanning multiple lines.
Segmentation fault: 11

$ solc --version
solc, the solidity compiler commandline interface
Version: 0.4.20+commit.3155dd80.Darwin.appleclang
bounty worthy bug
Source
picture wjmelements

Most helpful comment

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__Work has been started__.

  1. @alibabe

    has committed to working on this project to be completed 4 months, 4 weeks from now.

@gdipri01, __please see the below comments / questions regarding approach for this ticket from the bounty hunter(s):__

  • @alibabe: Im able to reproduce issue with similar error:

solc --ast node_modules/zeppelin-solidity/contracts/math/SafeMath.sol
Warning: This is a pre-release compiler version, please do not use it in production.
[1] 97139 segmentation fault solc --ast node_modules/zeppelin-solidity/contracts/math/SafeMath.sol

Will investigate on my environment first.

picture gitcoinbot on 10 May 2018
❤1 🎉1 😄1

All 28 comments

Trying on 0.4.21

wjmelements picture wjmelements on 13 Mar 2018

I have confirmed it still happens on 0.4.21.

$ solc --version
solc, the solidity compiler commandline interface
Version: 0.4.21+commit.dfe3193c.Darwin.appleclang
$ solc --ast ../pub/contracts/pub.sol 
Segmentation fault: 11
wjmelements picture wjmelements on 13 Mar 2018

@wjmelements Can you give us more information about your setup? OS version, C++ compiler version used to build solc, etc.? So far I cannot reproduce your issue.

ekpyron picture ekpyron on 13 Mar 2018 
$ clang --version
Apple LLVM version 8.0.0 (clang-800.0.42.1)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin

$ gcc --version
Configured with: --prefix=/Applications/Xcode.app/Contents/Developer/usr --with-gxx-include-dir=/usr/include/c++/4.2.1
Apple LLVM version 8.0.0 (clang-800.0.42.1)
Target: x86_64-apple-darwin16.7.0
Thread model: posix
InstalledDir: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin
wjmelements picture wjmelements on 14 Mar 2018 
$ uname -a
Darwin Williams-MacBook-Pro.local 16.7.0 Darwin Kernel Version 16.7.0: Thu Jan 11 22:59:40 PST 2018; root:xnu-3789.73.8~1/RELEASE_X86_64 x86_64
wjmelements picture wjmelements on 14 Mar 2018

@wjmelements Thanks! Would it be possible for to update your XCode version to 9.0.0 and then try to reproduce again? That's the only obvious difference between your and my setup, and I couldn't reproduce this issue so far.

erak picture erak on 14 Mar 2018

@wjmelements can you run it with lldb and paste the stack trace?

axic picture axic on 15 Mar 2018 
* thread #1: tid = 0x5d15, 0x00000001000188d3 solc`std::__1::__tree<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::__map_value_compare<dev::solidity::ASTNode const*, std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::less<dev::solidity::ASTNode const*>, true>, std::__1::allocator<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption> > >::__move_assign(std::__1::__tree<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::__map_value_compare<dev::solidity::ASTNode const*, std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::less<dev::solidity::ASTNode const*>, true>, std::__1::allocator<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption> > >&, std::__1::integral_constant<bool, true>) + 71, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=EXC_I386_GPFLT)
    frame #0: 0x00000001000188d3 solc`std::__1::__tree<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::__map_value_compare<dev::solidity::ASTNode const*, std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::less<dev::solidity::ASTNode const*>, true>, std::__1::allocator<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption> > >::__move_assign(std::__1::__tree<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::__map_value_compare<dev::solidity::ASTNode const*, std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::less<dev::solidity::ASTNode const*>, true>, std::__1::allocator<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption> > >&, std::__1::integral_constant<bool, true>) + 71
solc`std::__1::__tree<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::__map_value_compare<dev::solidity::ASTNode const*, std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::less<dev::solidity::ASTNode const*>, true>, std::__1::allocator<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption> > >::__move_assign:
->  0x1000188d3 <+71>: vmovaps %xmm0, (%rcx)
    0x1000188d7 <+75>: jmp    0x1000188dc               ; <+80>
    0x1000188d9 <+77>: movq   %r15, (%rbx)
    0x1000188dc <+80>: addq   $0x8, %rsp
wjmelements picture wjmelements on 15 Mar 2018 
(lldb) bt
* thread #1: tid = 0x793c, 0x00000001000188d3 solc`std::__1::__tree<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::__map_value_compare<dev::solidity::ASTNode const*, std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::less<dev::solidity::ASTNode const*>, true>, std::__1::allocator<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption> > >::__move_assign(std::__1::__tree<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::__map_value_compare<dev::solidity::ASTNode const*, std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::less<dev::solidity::ASTNode const*>, true>, std::__1::allocator<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption> > >&, std::__1::integral_constant<bool, true>) + 71, queue = 'com.apple.main-thread', stop reason = EXC_BAD_ACCESS (code=EXC_I386_GPFLT)
  * frame #0: 0x00000001000188d3 solc`std::__1::__tree<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::__map_value_compare<dev::solidity::ASTNode const*, std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::less<dev::solidity::ASTNode const*>, true>, std::__1::allocator<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption> > >::__move_assign(std::__1::__tree<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::__map_value_compare<dev::solidity::ASTNode const*, std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption>, std::__1::less<dev::solidity::ASTNode const*>, true>, std::__1::allocator<std::__1::__value_type<dev::solidity::ASTNode const*, dev::eth::GasMeter::GasConsumption> > >&, std::__1::integral_constant<bool, true>) + 71
    frame #1: 0x000000010000b705 solc`dev::solidity::CommandLineInterface::handleAst(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) + 1467
    frame #2: 0x000000010000c9dd solc`dev::solidity::CommandLineInterface::outputCompilationResults() + 57
    frame #3: 0x000000010000c767 solc`dev::solidity::CommandLineInterface::actOnInput() + 65
    frame #4: 0x000000010001a25a solc`main + 175
    frame #5: 0x00007fff5badf115 libdyld.dylib`start + 1
wjmelements picture wjmelements on 15 Mar 2018

__move_assign inside std::__tree - it is the heisenbug.

chriseth picture chriseth on 15 Mar 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__This issue now has a funding of 200.001 DAI (200.0 USD @ $1.0/DAI) attached to it.__

gitcoinbot picture gitcoinbot on 1 May 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__Work has been started__.

  1. @alibabe

    has committed to working on this project to be completed 4 months, 4 weeks from now.

@gdipri01, __please see the below comments / questions regarding approach for this ticket from the bounty hunter(s):__

  • @alibabe: Im able to reproduce issue with similar error:

solc --ast node_modules/zeppelin-solidity/contracts/math/SafeMath.sol
Warning: This is a pre-release compiler version, please do not use it in production.
[1] 97139 segmentation fault solc --ast node_modules/zeppelin-solidity/contracts/math/SafeMath.sol

Will investigate on my environment first.

gitcoinbot picture gitcoinbot on 10 May 2018
❤1 🎉1 😄1

@alibabe Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot picture gitcoinbot on 13 May 2018

@chriseth could you give some more explanation on

__move_assign inside std::__tree - it is the heisenbu

alibabe picture alibabe on 14 May 2018

@alibabe it might be related to a different version of the standard library being used at compile time (for the headers) and at link time. It only happens on mac os and only for a release build. I cannot tell much more apart from this, we investigated this bug for a long time but could not find anything.

chriseth picture chriseth on 14 May 2018

To clarify more, I got seg fault on all of the files I tested. Does this happen to you as well? Or it only happens on node_modules/zeppelin-solidity/contracts/math/SafeMath.sol

alibabe picture alibabe on 15 May 2018

Just about every contract I have tried with the --ast option has given sigsegv.

wjmelements picture wjmelements on 15 May 2018

Seems not only --ast has this issue, this bug happens to --ast-json and --ast-compact-json for me as well

alibabe picture alibabe on 15 May 2018

Yes, the bug is either a linking / compiler configuration problem, a bug in the stdlib of macos or a fundamental problem about how we use std::map in general.

chriseth picture chriseth on 15 May 2018

This issue seems is a very similar bug: https://github.com/CleverRaven/Cataclysm-DDA/issues/17714
Any insights?

alibabe picture alibabe on 17 May 2018

From that issue:

This diff fixes #17898, wherein the release (but not debug) build would crash if compiled with Clang on OS X. Apparently Clang, if made to optimize for release, doesn't auto-generate a function that is expected to exist (and that GCC does generate in release); the diff just manually implements that function to ensure that it's present.

In their case, it is a copy assignment operator, so it could help to manually add move assignment operators for some of our classes, but somehow I have the feeling that if that is really the problem, a compiler update should have been made in the meantime...

chriseth picture chriseth on 17 May 2018

I tried adding customized move assignment operator and copy assignment operator to GasConsumption and ASTNode with no luck. However, I am able to fix the issue by assigning the result of breakToStatementLevel to a local variable, then assign it back to gasCosts.

Let me know if this is enough

alibabe picture alibabe on 21 May 2018

@alibabe Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • [x] warning (3 days)
  • [ ] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot picture gitcoinbot on 25 May 2018

@chriseth @alibabe Please ignore the notice from @weberV, it's a bug on our side we're actively tracking! Apologies for the inconvenience.

vs77bb picture vs77bb on 27 May 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@alibabe due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • [x] warning (3 days)
  • [x] escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

gitcoinbot picture gitcoinbot on 28 May 2018

Still WIP. Also updated the pull request.

alibabe picture alibabe on 29 May 2018

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

__Work for 200.001 DAI (200.0 USD @ $1.0/DAI) has been submitted by__:

  1. @alibabe
  2. @alibabe
  3. @alibabe

@gdipri01 please take a look at the submitted work:

  • PR by @alibabe
  • PR by @alibabe
  • PR by @alibabe
gitcoinbot picture gitcoinbot on 1 Jun 2018

Hey,

I am trying to use solc --ast contracts/GnosisSafe.sol (https://www.github.com/gnosis/safe-contract) and receive a segmentation fault.

I am using solc 0.5.0+commit.1d4f565a.Darwin.appleclang (installed via brew) and other outputs work(e.g. solc --bin or solc --asm). Also for other contracts it is possible to perform this action (tested with solc --ast /=/ contracts/base/BaseSafe.sol).

I am running MacOS Mojave (10.14.1)

Is this related to this bug or should I open a new one?

rmeissner picture rmeissner on 25 Nov 2018
Was this page helpful?
0 / 5 - 0 ratings

Related issues

Dohtar1337 picture Dohtar1337  Â·  4Comments
bshastry picture bshastry  Â·  3Comments
madvas picture madvas  Â·  3Comments
chriseth picture chriseth  Â·  3Comments
axic picture axic  Â·  3Comments