Solidity: Prerelease warning made warning tests ineffective

Created on 26 Oct 2016  路  4Comments  路  Source: ethereum/solidity

Due to the fact that every prerelease version of a compiler emits a warning for every input, the tests that check for the existing of some warning are now ineffective. We should change these tests to check the actual warning text.

bug

Most helpful comment

This should be done for the errors too - we want to check for specific errors and not "it's fine if any error has happened".

All 4 comments

This should be done for the errors too - we want to check for specific errors and not "it's fine if any error has happened".

@pirapira your PR only said "trying to fix". Do you want this to be reopened?

Yes. The PR started to fix the problem in only one file. I knew the comment would close the issue, but I was too optimistic.

This has been done by now.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

chriseth picture chriseth  路  3Comments

chriseth picture chriseth  路  4Comments

axic picture axic  路  3Comments

AnthonyAkentiev picture AnthonyAkentiev  路  3Comments

chriseth picture chriseth  路  3Comments