Solidity-coverage: Please upgrade to fork of latest ganche-cli fork v0.6.7

[BrendanChou]

Needed for certain tests to run such as those that use the latest eth_signTypedData rpc call

[cgewecke]

@BrendanChou

Apologies, I published the beta last night and am going to try installing at dydx this afternoon/evening. You should be able to use whatever ganache-core version works best then.

Unless there are serious problems with the new version I might try to get away with not bumping testrpc-sc again - it's four forks that have to be synced with their upstream, re-hacked and then built together.

Also WDYT about ganache-core 480? I'm kind of worried that will break anyone using gas estimation...

[BrendanChou]

No worries, that makes sense. This isn't a huge blocker as I am just running necessary tests outside of coverage.

For the breaking change, I just now don't estimate gas in tests anymore, instead setting the gas amount to a static amount of 5mil or something.

Coverage adds a lot of gas usage, so for that I bumped it to like 100 mil and had to make sure to run coverage with increased block size

[cgewecke]

@BrendanChou

Out of curiosity, if testrpc-sc was republished with only the changes in ganache-core 460 would that work for you? i.e just bumping the eth-sig-util dep and changing the method signature there?

I ask because I've taken a look at dydx/solo (it's amazing!) and it's clear you've blazed some new ground :) I'd kind of like to circle back towards the end of the 0.7.0 work and see if solidity-coverage's new API is well designed enough that it's components can be integrated into scripts like yours. At the moment it's just trying to work in a very vanilla Truffle context.

[BrendanChou]

I believe that's the main change that I'm looking for, yes!

But again, I don't need that too badly (not blocking). You should focus on whatever is most impactful for 0.7.0 :)

[cgewecke]

@BrendanChou 0.6.7 has the eth-sig-util changes. Please just lmk if there are unforeseen problems / it's not working as expected.

[BrendanChou]

Amazing, looks good and works